← Back to issue list

store: add missing case for list-keys

View original Github issue

Metadata

Project
snapcraft
Number
#4230
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged: author could not push to snapcore branches, so the store list-keys fix (CRAFT-1804, LP#1996618) moved to #4234 and landed via merged PR #4245, commit 1c44a58fc on hotfix/7.5.

Resolution: closed superseded

Reason: Maintainer lengau commented on 2023-06-27 that it was "Moved to #4234 because I'm unable to push to snapcore branches". #4234 in turn was superseded by #4245, which merged into hotfix/7.5 as commit 1c44a58fc, adding the missing store list-keys handling for CRAFT-1804.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Now displays keys that are available on the system but not registered. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- https://bugs.launchpad.net/snapcraft/+bug/1996618 CRAFT-1804

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged: author could not push to snapcore branches, so the store list-keys fix (CRAFT-1804, LP#1996618) moved to #4234 and landed via merged PR #4245, commit 1c44a58fc on hotfix/7.5.
stealth/space-bunny-alpha — closed superseded Closed after being replaced by #4245, which merged into hotfix/7.5 as 1c44a58fc and added the missing store list-keys handling for CRAFT-1804.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #4234. The author closed this PR to consolidate changes after encountering push permission issues. The original changes added handling for unregistered system keys in the list-keys command.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by pull request #4234. Closed due to branch push restrictions; the author migrated the implementation to the replacement pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#4234 (confidence 97%)

    Identical PR title/diff; lengau moved the work here after being unable to push to snapcore branches

  • Likely Fixed By: canonical/snapcraft#4245 (confidence 95%)

    Merged PR that cherry-picked the change, landing as commit 1c44a58fc on hotfix/7.5

  • Related To: snapcraft#4245 (confidence 80%)

    git log confirms 1c44a58fc 'store: add missing case for list-keys (#4245)'

Related issues

Issue Project State Summary Similarity
#4245 store: add missing case for list-keys snapcraft merged Merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys case for CRAFT-1804; it cherry-picked the fix from #4234.
87%
#4229 store: add missing case for list-keys snapcraft closed Closed unmerged. Its store list-keys fix was superseded by #4234 and shipped via merged PR #4245 (commit 1c44a58fc), which now displays system keys that exist but are not registered.
86%
#4234 store: add missing case for list-keys snapcraft closed The missing store list-keys case was delivered through #4245, merged into hotfix/7.5 as 1c44a58fc; #4234 was then closed.
86%