store: add missing case for list-keys
Metadata
Current evaluation
Merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys case for CRAFT-1804; it cherry-picked the fix from #4234.
Resolution: closed resolved
Reason: PR #4245 merged into hotfix/7.5 as commit 1c44a58fc, adding the missing store list-keys handling for CRAFT-1804. The maintainer also noted that the expected Pyright failure was addressed separately in #4243.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Cherry-picked hotfix for https://github.com/snapcore/snapcraft/pull/4234
CRAFT-1804
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into hotfix/7.5 as 1c44a58fc, adding the missing store list-keys case for CRAFT-1804; it cherry-picked the fix from #4234. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4245 merged into hotfix/7.5 as 1c44a58fc, adding the missing list-keys case for CRAFT-1804. It cherry-picked #4234. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into hotfix/7.5 as a cherry-picked hotfix adding a missing case for list-keys. Resolves CRAFT-1804. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into hotfix/7.5 as a cherry-picked hotfix adding a missing list-keys case to the store module. Resolves CRAFT-1804. Pyright errors were fixed in PR #4243. Achieved 100% diff coverage upon merge. |
Update history
No update history recorded yet.
Related work
-
Duplicate Of:
canonical/snapcraft#4234
(confidence 99%)
PR #4245 delivered the same CRAFT-1804 list-keys fix as a cherry-picked hotfix from #4234.
-
Related To:
canonical/snapcraft#4243
(confidence 95%)
The maintainer cited #4243 as the separate fix for the expected Pyright failure.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4234 store: add missing case for list-keys | snapcraft | closed | The missing store list-keys case was delivered through #4245, merged into hotfix/7.5 as 1c44a58fc; #4234 was then closed. | |
| #4230 store: add missing case for list-keys | snapcraft | closed | PR closed unmerged: author could not push to snapcore branches, so the store list-keys fix (CRAFT-1804, LP#1996618) moved to #4234 and landed via merged PR #4245, commit 1c44a58fc on hotfix/7.5. | |
| #4229 store: add missing case for list-keys | snapcraft | closed | Closed unmerged. Its store list-keys fix was superseded by #4234 and shipped via merged PR #4245 (commit 1c44a58fc), which now displays system keys that exist but are not registered. |