← Back to issue list

chore(spread): enable pkg-repo tests for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4621
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4621 (commit 57783b2c2), enabling core24 pkg-repo Spread tests and removing the redundant --use-lxd toggle because LXD was already the default.

Resolution: closed resolved

Reason: The pull request was approved and merged as commit 57783b2c2. It enabled the core24 pkg-repo tests and simplified their invocation by removing the redundant --use-lxd option.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This mainly removes the --use-lxd toggle, there is no reason for it as it is the default. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4621 (commit 57783b2c2), enabling core24 pkg-repo Spread tests and removing the redundant --use-lxd toggle because LXD was already the default.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4621 via 57783b2c2, enabling core24 pkg-repo spread tests and removing the redundant --use-lxd toggle.
qwen/qwen3.6-35b-a3b — — Merged. Enabled pkg-repo tests for core24 and removed the unused --use-lxd toggle, which was already the default. Changes passed CI and code review.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enabled pkg-repo tests for core24 and removed the redundant --use-lxd toggle, as LXD is the default. Changes passed all tests and code coverage checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4689 chore(spread): remove remove hook test for core24 snapcraft merged Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement.
76%
#4720 chore(core24): update package for linter spread test snapcraft merged Merged PR #4720 (commit 429a69ce9) updated the package used by the core24 linter spread test after its time_t change.
75%
#4674 chore(spread): miscellaneous spread fixes for core24 snapcraft merged Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5).
73%
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass.
72%
#5856 fix(spread): pack with lxd for core20 base tests snapcraft merged Merged PR #5856 (commit 66b9ae9f4) updated Spread core20-base tests to pack with LXD.
70%