← Back to issue list

chore(spread): enable pkg-repo tests for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4621
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Enabled pkg-repo tests for core24 and removed the unused --use-lxd toggle, which was already the default. Changes passed CI and code review.

Suggested action:

No scores available.

Issue body

This mainly removes the --use-lxd toggle, there is no reason for it as it is the default. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Enabled pkg-repo tests for core24 and removed the unused --use-lxd toggle, which was already the default. Changes passed CI and code review.
qwen3.6-35b-a3b-mtp-q6 Merged. Enabled pkg-repo tests for core24 and removed the redundant --use-lxd toggle, as LXD is the default. Changes passed all tests and code coverage checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Enabled pkg-repo tests for core24 in the spread configuration by removing the redundant --use-lxd toggle. Changes passed automated coverage checks and were successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4689 chore(spread): remove remove hook test for core24 snapcraft merged Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines.
77%
#565 chore: enable tests on 24.04 LTS rockcraft merged Merged following approval by three reviewers and passing CI checks. The change enables automated testing for Ubuntu 24.04 LTS, modifying 2 files with 9 added lines.
74%
#5502 chore(merge): 8.9.2 into main snapcraft merged Merged version 8.9.2 into main by maintainer mr-cal. Approved by two reviewers and passing most CI checks despite one failing test. Adds YAML syntax error reporting tests and project variable evaluations for core24 and core22.
73%
#4720 chore(core24): update package for linter spread test snapcraft merged Merged a one-line package update for a linter spread test to address a time_t compatibility issue. Approved by two reviewers and passed CI checks.
72%
#4674 chore(spread): miscellaneous spread fixes for core24 snapcraft merged Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff.
70%
#541 chore(deps): update dependency packaging to v24 rockcraft merged Merged automated dependency update upgrading packaging from v23.2 to v24.0. Approved by two reviewers and passed CI checks. Successfully integrated into main via Renovate bot.
70%