tests: remove core24 snap workarounds (#4761)
Metadata
Current evaluation
Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass.
Resolution: closed resolved
Reason: PR #4763 was merged into main as commit 87fc77aca, cherry-picking the hotfix/8.2 change from #4761 (7cdd9b087). The diff removed 22 lines of core24-specific test workarounds and was approved by two reviewers with no CI failures.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Cherry-pick #4761 onto `main` so CI can pass
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4763 cherry-picked #4761 onto main as commit 87fc77aca, removing 22 lines of core24 test workarounds to restore CI. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main as 87fc77aca, cherry-picking #4761 to remove 22 lines of obsolete core24 test workarounds so CI could pass. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4763 as 87fc77aca, cherry-picking #4761 onto main to remove 22 lines of core24 test workarounds and restore CI. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged via #4763 (commit 87fc77aca), cherry-picking #4761 onto main to remove 22 lines of core24 test workarounds and restore CI. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into main after two approvals and passing CI. The change cherry-picks test updates to remove core24 snap workarounds, resolving CI failures by deleting 22 lines of legacy code in a single file. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Cherry-picked onto main to remove outdated core24 snap workarounds from tests, resolving CI failures. Merged as #4761. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#4761
(confidence 97%)
Original PR merged as 7cdd9b087 on hotfix/8.2; #4763 cherry-picked it onto main.
-
Related To:
canonical/snapcraft#4750
(confidence 30%)
Adjacent core24 spread-test cleanup dropping 'grade: devel' from core24 tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca. | |
| #6009 test: remove core20 spread tests | snapcraft | merged | Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675). | |
| #4748 tests: re-enable core24 linter spread test check | snapcraft | closed | Closed unmerged; the core24 linter spread-test re-enable was superseded by canonical/snapcraft#4751, which tracks fixing the core22/core24 linker symbol lookup error. | |
| #3026 spread tests: add core20 and cleanup systems | snapcraft | merged | Merged #3026 in commit d006134d4, adding core20 spread tests, simplifying setup to install only the Snap, and cleaning up test systems. | |
| #2417 fix: fix a series of breaking spread tests | charmcraft | merged | Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking. | |
| #4932 Migrate or copy core20 and core22 spread tests to core24 | snapcraft | closed | Core24 spread-test coverage was expanded via merged PR snapcraft#5209 (commit 56713c384), enabling plugin tests across 132 files. | |
| #4056 spread: core24 testing infra | snapcraft | merged | Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639). | |
| #4582 test: add core24 component spread tests | snapcraft | merged | Merged #4582 into feature/components, adding core24 component spread tests by flattening and copying existing tests after CI passed. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers. |