chore(spread): remove remove hook test for core24
Metadata
Current evaluation
Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement.
Resolution: closed resolved
Reason: The PR was approved and merged as commit 8ce88c44b. It deleted the unrelated core24 remove-hook spread test and its associated fixture files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This tests the removal of base instances on snapcraft removal itself, it has nothing to do with enabling core24 in snapcraft.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4689 (commit 8ce88c44b), deleting a core24 remove-hook spread test because it tested base-instance cleanup, not core24 enablement. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4689 via commit 8ce88c44b, removing the core24 remove-hook spread test because it was unrelated to core24 enablement. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a chore to remove a spread test for core24 base instance removal, as it was unrelated to enabling core24 in snapcraft. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4056
(confidence 65%)
That merged PR added the core24 spread testing infrastructure with which this cleanup was associated.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4674 chore(spread): miscellaneous spread fixes for core24 | snapcraft | merged | Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5). | |
| #4621 chore(spread): enable pkg-repo tests for core24 | snapcraft | merged | Merged PR #4621 (commit 57783b2c2), enabling core24 pkg-repo Spread tests and removing the redundant --use-lxd toggle because LXD was already the default. | |
| #4668 chore(spread): core22 provider setup cleanup | snapcraft | merged | Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 Spread provider setup and making cleanup target the correct provider. | |
| #4634 chore: spread cleanup | snapcraft | merged | Merged spread cleanup in #4634, simplifying 85 files with 115 additions and 358 deletions; Codecov reported all modified coverable lines were tested. | |
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca. |