chore(spread): remove remove hook test for core24
Metadata
Current evaluation
Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines.
Suggested action: —
No scores available.
Issue body
This tests the removal of base instances on snapcraft removal itself, it has nothing to do with enabling core24 in snapcraft.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a chore to remove a spread test for core24 base instance removal, as it was unrelated to enabling core24 in snapcraft. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a chore removing an unrelated spread test for the core24 base instance removal hook. The test was unnecessary for enabling core24 in snapcraft and has been successfully integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4674 chore(spread): miscellaneous spread fixes for core24 | snapcraft | merged | Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff. | |
| #4668 chore(spread): core22 provider setup cleanup | snapcraft | merged | Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files. | |
| #4634 chore: spread cleanup | snapcraft | merged | Merged by maintainer sergiusens after three reviewers approved. The PR cleaned up spread configuration across 85 files, removing 358 lines and adding 115. All CI checks passed with 100% coverage on modified code. | |
| #4621 chore(spread): enable pkg-repo tests for core24 | snapcraft | merged | Merged. Enabled pkg-repo tests for core24 and removed the unused --use-lxd toggle, which was already the default. Changes passed CI and code review. | |
| #753 chore(services/testing): reduce spread verbosity level | craft-application | merged | Merged changes that disable verbose mode for the spread test command to reduce output noise. Approved by reviewers, passed all CI checks, and integrated into the codebase. | |
| #5030 chore(merge): 8.4.0 into main | snapcraft | merged | Merged version 8.4.0 into main. Approved by two reviewers with passing CI checks. The update modified 33 files, adding 930 lines and removing 151. A maintainer clarified an unrelated launchpad 503 error triggered a core20 spread test failure. | |
| #1321 chore(snap): base migration from core20 to core22 | charmcraft | merged | Merged the snap base migration from core20 to core22, resolving #1320 and CRAFT-2117. The change modified two files, removing 83 lines and adding 46. Approved by two reviewers, the update was integrated despite 22 unresolved comments. | |
| #5502 chore(merge): 8.9.2 into main | snapcraft | merged | Merged version 8.9.2 into main by maintainer mr-cal. Approved by two reviewers and passing most CI checks despite one failing test. Adds YAML syntax error reporting tests and project variable evaluations for core24 and core22. | |
| #368 chore(snap): base migration from core20 to core22 | rockcraft | merged | Merged the snap base migration from core20 to core22, resolving issue #373 and CRAFT-2118. Approved by two reviewers, the update modifies four files with 113 additions and 24 deletions. All review feedback was addressed prior to final merge. | |
| #5136 chore: migrate snapcraft itself to core24 | snapcraft | merged | Migrating snapcraft to core24 was approved by two reviewers, passed CI checks, and successfully merged. The update modified 9 files to align the project with the core24 base. |