← Back to issue list

chore: spread cleanup

View original Github issue

Metadata

Project
snapcraft
Number
#4634
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged spread cleanup in #4634, simplifying 85 files with 115 additions and 358 deletions; Codecov reported all modified coverable lines were tested.

Resolution: closed resolved

Reason: PR #4634 was merged after approval by three reviewers. The approved change reduced the spread test configuration by 243 net lines.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged spread cleanup in #4634, simplifying 85 files with 115 additions and 358 deletions; Codecov reported all modified coverable lines were tested.
stealth/space-bunny-alpha — closed resolved Merged PR #4634 cleaned up spread configuration across 85 files, removing 358 lines and adding 115.
stealth/space-bunny-alpha — closed resolved Merged PR #4634 cleaned up spread configuration across 85 files (-358/+115 lines), with three approvals and no failing CI checks.
qwen/qwen3.6-35b-a3b — — Merged by maintainer sergiusens after three reviewers approved. The PR cleaned up spread configuration across 85 files, removing 358 lines and adding 115. All CI checks passed with 100% coverage on modified code.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer-led chore PR for spread cleanup. Codecov confirmed all modified lines are covered with 89.16% project coverage. The changes were successfully integrated into the feature/craft-application branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4674 chore(spread): miscellaneous spread fixes for core24 snapcraft merged Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5).
76%
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
75%
#4448 chore(deps): update dependencies snapcraft merged Merged #4448 updated dependency pins across 8 files (+123/-119). Two reviewers approved it, and Codecov reported all modified coverable lines were covered.
74%
#117 chore: clean up cruft craft-actions closed Merged PR #117 as commit 37d00fc, removing 117 lines from nine files to clean repository cruft ahead of v1.
73%
#2028 chore: two small non-code changes charmcraft merged Merged PR #2028 incorporated two small non-code updates across two files (+5/-2), with approval from two reviewers.
73%
#11 chore: enable spread tests snapcraft-rocks merged Merged PR #11 enabled Spread tests on spread-capable self-hosted CI runners and downgraded actions/checkout to v3 for Node compatibility.
72%
#4668 chore(spread): core22 provider setup cleanup snapcraft merged Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 Spread provider setup and making cleanup target the correct provider.
72%
#753 chore(services/testing): reduce spread verbosity level craft-application merged Merged PR #753 removed forced verbose mode from Spread test execution, reducing output noise from the test command.
72%
#918 chore(merge): feature/pro-sources into main craft-providers merged Merged feature/pro-sources into main via #918 (commit b56ff14), completing CRAFT-5012 with all CI checks passing and 1,594 additions across 9 files.
71%
#4689 chore(spread): remove remove hook test for core24 snapcraft merged Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement.
71%