chore(spread): core22 provider setup cleanup
Metadata
Current evaluation
Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files.
Suggested action: —
No scores available.
Issue body
Also make the clean actually clean the correct provider
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of the core22 provider setup in spread configuration. The change fixes the clean command to target the correct provider. Passed all lint and test checks, achieving full coverage on modified lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of the core22 provider setup in spread, fixing the clean command to target the correct provider. Passed all checks and received positive Codecov coverage reports. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4634 chore: spread cleanup | snapcraft | merged | Merged by maintainer sergiusens after three reviewers approved. The PR cleaned up spread configuration across 85 files, removing 358 lines and adding 115. All CI checks passed with 100% coverage on modified code. | |
| #4689 chore(spread): remove remove hook test for core24 | snapcraft | merged | Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines. | |
| #4674 chore(spread): miscellaneous spread fixes for core24 | snapcraft | merged | Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff. | |
| #1575 chore: make spread config a bit nicer | charmcraft | merged | Merged maintainer lengau's pull request to improve spread configuration formatting. The change added four lines across two files. Approved by two reviewers with zero unresolved comments and no CI checks required. | |
| #3877 tests: enable provider spread tests for core22 | snapcraft | merged | Merged updates enabling provider spread tests for core22. The test directory was renamed from build-providers to providers, and legacy tests were relocated to a legacy subdirectory. Approved and merged following successful CI validation. | |
| #753 chore(services/testing): reduce spread verbosity level | craft-application | merged | Merged changes that disable verbose mode for the spread test command to reduce output noise. Approved by reviewers, passed all CI checks, and integrated into the codebase. | |
| #2264 chore: migrate provider test from GHA to spread | charmcraft | merged | Merged after two reviewers approved. The update migrated provider tests from GitHub Actions to Spread. Ephemeral Spread failures were resolved on re-run, passing CI and landing the commit in the merge queue. | |
| #603 chore: update spread test to use utility functions | fetch-service | merged | Merged maintainer PR replacing direct curl calls in spread tests with utility functions from spread/utils.sh and extending create_session to accept optional secret definitions. Approved by two reviewers with all CI checks passing. | |
| #3714 spread: enable core22 | snapcraft | merged | Merged into snapcraft/7.0 after reviewer approval and passing CI checks. The change enables core22 in the spread configuration across 36 files (+112/-58 lines). Code coverage remained unchanged upon merge. |