chore(spread): core22 provider setup cleanup
Metadata
Current evaluation
Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 Spread provider setup and making cleanup target the correct provider.
Resolution: closed resolved
Reason: The cleanup was approved with no unresolved review comments and merged as commit 5d03a0a6b.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also make the clean actually clean the correct provider
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 Spread provider setup and making cleanup target the correct provider. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 spread provider setup so cleanup targets the correct provider. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4668 merged as 5d03a0a6b, cleaning up core22 spread provider setup so cleanup targets the correct provider. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4668 as 5d03a0a6b, cleaning up core22 Spread provider setup across 12 files and making cleanup target the correct provider. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #4668 (commit 5d03a0a6b), cleaning up the core22 spread provider setup and ensuring cleanup targets the correct provider. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #4668 (5d03a0a6), cleaning the core22 Spread provider setup and fixing cleanup to target the correct provider. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of the core22 provider setup in spread configuration. The change fixes the clean command to target the correct provider. Passed all lint and test checks, achieving full coverage on modified lines. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4674 chore(spread): miscellaneous spread fixes for core24 | snapcraft | merged | Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5). | |
| #1773 chore: remove unused providers module | charmcraft | closed | PR #1773 was closed unmerged after 720 days of inactivity; the providers cleanup was later completed by merged PR #1776 at commit 027696be. | |
| #4689 chore(spread): remove remove hook test for core24 | snapcraft | merged | Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement. | |
| #46 chore(merge): 'core22-7' into 'core22-8' | snapcraft-rocks | closed | Closed unmerged; maintainer requested a fresh core22-7-to-core22-8 merge after clearing the PR backlog. | |
| #4634 chore: spread cleanup | snapcraft | merged | Merged spread cleanup in #4634, simplifying 85 files with 115 additions and 358 deletions; Codecov reported all modified coverable lines were tested. | |
| #2264 chore: migrate provider test from GHA to spread | charmcraft | merged | PR #2264 by sergiusens merged via commit 8426c4a3, moving the provider test from GitHub Actions to Spread; after lengau re-ran transient Spread failures it landed in the merge queue. +15/-44 lines, 2 files. | |
| #5030 chore(merge): 8.4.0 into main | snapcraft | merged | Merged the 8.4.0 release branch into main as commit c39807547. The noted core20 spread failure was an unrelated Launchpad 503. |