← Back to issue list

refactor: rebase onto craft-application 5

View original Github issue

Metadata

Project
snapcraft
Number
#5349
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#5349 as ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and restoring .snapcraft.yaml project detection for core24.

Resolution: closed resolved

Reason: PR #5349 was approved and merged as commit ddbf2a6f8, completing the craft-application 5 rebase. The merged change also restored .snapcraft.yaml project detection associated with snapcraft#5083.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- A work-in-progress of rebasing onto craft-application 5. Bugs/PRs from this effort: * https://github.com/canonical/craft-application/pull/684 * https://github.com/canonical/craft-application/pull/689 * https://github.com/canonical/craft-application/issues/690 * https://github.com/canonical/craft-application/issues/692 * https://github.com/canonical/craft-application/issues/693 Possibly fixes #5083 (requires new regression tests) (CRAFT-4337)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#5349 as ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and restoring .snapcraft.yaml project detection for core24.
stealth/space-bunny-alpha — closed resolved Merged as commit ddbf2a6f8: rebased Snapcraft onto craft-application 5 (CRAFT-4337), fixing core24 project detection. Resolved #5083 and #5336; shipped in Snapcraft 8.9.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5349 as commit ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and resolving .snapcraft.yaml project detection in Snapcraft 8.9 for core24.
stealth/space-bunny-alpha — closed resolved Merged #5349 as ddbf2a6f8, updating Snapcraft to craft-application 5 across 45 files. It closed update task #5336 and may have fixed .snapcraft.yaml detection in #5083.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#5349, rebasing Snapcraft onto craft-application 5 (45 files; +1732/−1560). Potentially fixes #5083, pending regression tests.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactor rebasing the codebase onto craft-application 5. The update integrates upstream dependency changes and related craft-application fixes, potentially resolving issue #5083.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#5083 (confidence 95%)

    The rebase restored .snapcraft.yaml recognition for core24, addressing the reported project-file detection failure.

  • Related To: canonical/craft-application#684 (confidence 90%)

    Explicitly listed as a bug or PR arising from the craft-application 5 rebase effort.

  • Related To: canonical/craft-application#689 (confidence 90%)

    Explicitly listed as a bug or PR arising from the craft-application 5 rebase effort.

  • Related To: canonical/craft-application#690 (confidence 90%)

    Explicitly listed as a bug or PR arising from the craft-application 5 rebase effort.

  • Related To: canonical/craft-application#692 (confidence 90%)

    Explicitly listed as a bug or PR arising from the craft-application 5 rebase effort.

  • Related To: canonical/craft-application#693 (confidence 90%)

    Explicitly listed as a bug or PR arising from the craft-application 5 rebase effort.

Related issues

Issue Project State Summary Similarity
#5336 Update snapcraft to craft-application 5 snapcraft closed Snapcraft was rebased onto craft-application 5 by merged PR #5349 (commit ddbf2a6f8), completing the upgrade requested to unblock #5270.
84%
#4659 fix: update to craft-application latest snapcraft merged Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.
77%
#5083 ".snapcraft.yaml" not picked up as a project file snapcraft closed Fixed in Snapcraft 8.9 for core24 by PR #5349, which rebased Snapcraft onto craft-application 5 and restored .snapcraft.yaml detection.
77%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged as c9b6941d4, replacing Snapcraft-specific application logic with craft-app functionality (36 additions and 49 deletions across three files).
77%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged PR #4573 as commit 1366effa9, updating Snapcraft to use craft-application from its main branch.
75%
#5239 refactor: use craft-application's remote-build snapcraft merged Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044.
74%
#4693 feat: core24 using Craft Application and core22 components snapcraft merged Merged as commit ab1c86df3: snaps with base core24 are now built using Craft Application and core22 components, a large change (284 files, +10487/-1939) in snapcraft.
74%
#1366 build(deps): bump craft-application to 7.2.1 rockcraft closed Closed unmerged as superseded by canonical/snapcraft#6409, which merged the same craft-application 7.2.1 bump in commit 25dd38674.
73%
#4653 feat(craft-application): support remote build snapcraft closed Closed unmerged; superseded by canonical/snapcraft#4664 (commit 57d184af7), which landed the same craft-application remote build support for core24.
73%
#4560 feat(craft-application): initial support snapcraft merged Merged PR #4560 as 98550856e, adding initial craft-application support with fallback to Snapcraft's existing logic.
72%