refactor: rebase onto craft-application 5
Metadata
Current evaluation
Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
A work-in-progress of rebasing onto craft-application 5.
Bugs/PRs from this effort:
* https://github.com/canonical/craft-application/pull/684
* https://github.com/canonical/craft-application/pull/689
* https://github.com/canonical/craft-application/issues/690
* https://github.com/canonical/craft-application/issues/692
* https://github.com/canonical/craft-application/issues/693
Possibly fixes #5083 (requires new regression tests)
(CRAFT-4337)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor rebasing the codebase onto craft-application 5. The update integrates upstream dependency changes and related craft-application fixes, potentially resolving issue #5083. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after rebasing the codebase onto craft-application 5. The update incorporates upstream fixes and may resolve issue #5083. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #4659 fix: update to craft-application latest | snapcraft | merged | Merged. Consolidates fixes from PRs #4616, #4643, and #4651 to update craft-application to the latest version and accommodate its main branch breaking changes. Approved by two reviewers, passed CI, and successfully merged. | |
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #5593 build(deps): update craft-application to 5.4.0 | snapcraft | merged | Merged after approval by two reviewers. Updates the craft-application dependency to version 5.4.0 across two files. All required CI checks passed, and the change was successfully integrated. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. |