← Back to issue list

fix: catch remote build errors

View original Github issue

Metadata

Project
snapcraft
Number
#5052
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #5052 (commit 741e36eb9), updating craft-application to 4.2.4 so remote-build errors are caught as CraftErrors and include documentation links; fixes #4908.

Resolution: closed resolved

Reason: PR #5052 merged as commit 741e36eb9. It upgraded craft-application to 4.2.4, whose RemoteBuild errors subclass CraftError, allowing Snapcraft to report them correctly and resolving #4908.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- * bump craft-application to 4.2.4 * Adds documentation links to `RemoteBuild` and `ESM` errors * Catches `RemoteBuild` errors rather than raising them as internal errors ## craft-application ### 4.2.4 (2024-Sep-20) #### Remote build - Remote build errors are now a subclass of ``CraftError``. Fixes #4908 (CRAFT-3101)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #5052 (commit 741e36eb9), updating craft-application to 4.2.4 so remote-build errors are caught as CraftErrors and include documentation links; fixes #4908.
stealth/space-bunny-alpha — closed resolved Merged as 741e36eb9: bumps craft-application to 4.2.4 (RemoteBuild errors now subclass CraftError) and makes snapcraft/application.py catch remote.RemoteBuildError, emitting it with a /explanation/remote-build doc slug. Fixes #4908.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#5052 (741e36eb9): craft-application 4.2.4 makes RemoteBuild errors CraftError subclasses, so Snapcraft can catch them and show documentation links; fixes #4908.
stealth/space-bunny-alpha — closed resolved Merged PR #5052: catches RemoteBuild errors and adds documentation links, updating craft-application to 4.2.4.
stealth/space-bunny-alpha — closed resolved Merged PR #5052 bumped craft-application to 4.2.4, making RemoteBuild errors CraftError subclasses so Snapcraft catches them and links to RemoteBuild and ESM documentation; fixes #4908.
qwen/qwen3.6-35b-a3b — — Merged update bumping craft-application to 4.2.4. Replaces internal error raises with caught RemoteBuild exceptions now subclassed as CraftError. Resolves #4908 following CI passes and two approvals.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix updating craft-application to 4.2.4, catching RemoteBuild errors as CraftError instances instead of internal errors, and resolving issue #4908.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4908 (confidence 100%)

    The remote-build internal-error issue explicitly fixed by PR #5052.

  • Likely Fixed By: canonical/craft-application#482 (confidence 99%)

    Merged upstream change made RemoteBuild errors subclasses of CraftError and released in 4.2.4.

Related issues

Issue Project State Summary Similarity
#4908 remote build: stop raising internal errors snapcraft closed Remote-build errors now produce actionable messages and documentation links via merged PR #5052 (741e36eb9), updating craft-application to 4.2.4.
86%
#482 refactor: subclass remote-build errors from CraftError craft-application merged Merged craft-application#482 as be2750d8, making RemoteBuild errors CraftError subclasses, moving details into brief messages, and documenting release 4.2.4.
82%
#5239 refactor: use craft-application's remote-build snapcraft merged Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044.
72%
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab.
72%
#4793 fix(remote-build): don't fail with certain archs snapcraft merged Merged into the hotfix branch as commit 53ec55cef, fixing architecture-specific remote-build failures from #4780, with companion support in craft-application#343.
71%
#5223 remote-build: refactor onto craft-application's command snapcraft closed Remote-build was refactored onto craft-application's RemoteBuild in merged PR #5239 (commit f31d99498), bringing the requested upstream improvements.
70%
#4480 fix(remote): return error when remote build failed snapcraft merged Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142.
70%