← Back to issue list

refactor: use craft-application's remote-build

View original Github issue

Metadata

Project
snapcraft
Number
#5239
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044.

Resolution: closed resolved

Reason: PR #5239 was approved and merged into main at commit f31d99498, completing the remote-build refactor. The maintainer confirmed the merge after rebasing to resolve CLA issues.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- CRAFT-4044.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#5239 as commit f31d99498, replacing Snapcraft’s remote-build implementation with craft-application’s command for CRAFT-4044.
qwen/qwen3.6-35b-a3b — — Merged after three approvals. Author rebased to fix CLA. @mr-cal merged without waiting for core20 spread tests, as changes do not affect core20; related tests will run in PR #5259.
qwen3.6-35b-a3b-mtp-q6 — — Merged after author rebased to resolve CLA issues. Maintainer merged without waiting for core20 spread tests, as changes do not affect core20. Remote build validation deferred to PR #5259.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#5223 (confidence 99%)

    The tracking issue requested this refactor onto craft-application’s remote-build command.

  • Related To: canonical/craft-application#586 (confidence 96%)

    Merged craft-application PR #586 added the generalized remote-build command used by Snapcraft PR #5239.

Related issues

Issue Project State Summary Similarity
#5223 remote-build: refactor onto craft-application's command snapcraft closed Remote-build was refactored onto craft-application's RemoteBuild in merged PR #5239 (commit f31d99498), bringing the requested upstream improvements.
84%
#4653 feat(craft-application): support remote build snapcraft closed Closed unmerged; superseded by canonical/snapcraft#4664 (commit 57d184af7), which landed the same craft-application remote build support for core24.
81%
#4664 feat(craft-application): support remote build snapcraft merged PR #4664 by syu-w merged (commit 57d184af7), adding remote build support to craft-application in Snapcraft, including --platform and --build-for handling. Shipped in the 8.0.0 release notes as the new core24 remote-builder.
80%
#300 Remote-build: use craft-application for core22 craft-application closed Core22 remote builds moved to craft-application in merged Snapcraft PR #4724 (commit 9905f2831), removing the legacy core22 build path.
80%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged as c9b6941d4, replacing Snapcraft-specific application logic with craft-app functionality (36 additions and 49 deletions across three files).
75%
#5384 remote build: snapcraft incorrectly follows symlinks snapcraft open remote-build previously failed while copying dangling symlinks; craft-application 7.1.1 fixed this via PR #1104, and Snapcraft now requires craft-application >=7.4.1.
75%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged PR #4573 as commit 1366effa9, updating Snapcraft to use craft-application from its main branch.
74%
#482 refactor: subclass remote-build errors from CraftError craft-application merged Merged craft-application#482 as be2750d8, making RemoteBuild errors CraftError subclasses, moving details into brief messages, and documenting release 4.2.4.
74%
#4659 fix: update to craft-application latest snapcraft merged Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.
74%
#5349 refactor: rebase onto craft-application 5 snapcraft merged Merged in snapcraft#5349 as ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and restoring .snapcraft.yaml project detection for core24.
74%