refactor: use craft-application's remote-build
Metadata
Current evaluation
Merged after three approvals. Author rebased to fix CLA. @mr-cal merged without waiting for core20 spread tests, as changes do not affect core20; related tests will run in PR #5259.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
CRAFT-4044.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after three approvals. Author rebased to fix CLA. @mr-cal merged without waiting for core20 spread tests, as changes do not affect core20; related tests will run in PR #5259. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after author rebased to resolve CLA issues. Maintainer merged without waiting for core20 spread tests, as changes do not affect core20. Remote build validation deferred to PR #5259. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Refactored to use craft-application's remote-build. The branch was rebased to resolve CLA issues. Merged without waiting for core20 spread tests, as changes do not affect core20, with testing deferred to PR #5259. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4586 refactor: move core22 commands for versioned implementation | snapcraft | merged | Merged a pure rename refactor moving core22 commands for versioned implementation. Approved by four reviewers and passed CI. Full spread tests were enabled per request; failures attributed to external craft-application updates. | |
| #5007 refactor(application): commands, pre-run validation | snapcraft | merged | Merged after approval and CI. Refactored command handling and pre-run validation using craft-cli groups. Improved error formatting, targeted SNAPCRAFT_REMOTE_BUILD_STRATEGY validation, and fixed core20/core24 compatibility. Resolves #4911 and #5008. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #5349 refactor: rebase onto craft-application 5 | snapcraft | merged | Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes. | |
| #4830 refactor: migrate commands to craft-application | snapcraft | merged | Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742. | |
| #2720 remote build: switch from core to core18 | snapcraft | merged | Merged change switches remote build base from core to core18, aligning with snapcraft edge. Approved, passed CI, and modified one file. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #4384 refactor(remote-build): reorganize functions | snapcraft | merged | Merged a two-commit refactor reorganizing remote-build functions to prepare for issue #4322. Approved by two reviewers, passed CI checks, and modified two files with a net reduction of 40 lines. |