refactor(app): use more code from craft-app
Metadata
Current evaluation
Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor to integrate more code from craft-app. The change passed automated code coverage checks at 89.49%, verifying all modified lines were tested. Successfully integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring to integrate additional craft-app code. Changes passed linting and tests, with Codecov confirming full coverage on modified lines. Successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). | |
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #4679 refactor(docs): use more docs from craft-parts | snapcraft | merged | Merged documentation refactor replacing duplicated content with direct references or includes from shared craft-parts docs. Approved by two reviewers, passed CI, modified 18 files, and maintained 100% test coverage on changed lines. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #515 refactor(docs): use more docs from craft-parts | rockcraft | merged | Merged a documentation refactor simplifying the repository by directly referencing or embedding shared craft-parts docs. Approved by two reviewers, the update modifies 19 files, adding 61 and removing 38 lines. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. |