refactor(app): use more code from craft-app
Metadata
Current evaluation
Merged as c9b6941d4, replacing Snapcraft-specific application logic with craft-app functionality (36 additions and 49 deletions across three files).
Resolution: closed resolved
Reason: PR #4682 was approved by two reviewers and merged as commit c9b6941d4. The refactor reused more craft-app functionality and had no unresolved review comments.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as c9b6941d4, replacing Snapcraft-specific application logic with craft-app functionality (36 additions and 49 deletions across three files). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/snapcraft#4682 to reuse more craft-app functionality, a 36-line addition and 49-line deletion across three files, approved by two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactor to integrate more code from craft-app. The change passed automated code coverage checks at 89.49%, verifying all modified lines were tested. Successfully integrated into the main branch. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#4693
(confidence 78%)
Part of the broader core24 integration that used Craft Application alongside core22 components.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5349 refactor: rebase onto craft-application 5 | snapcraft | merged | Merged in snapcraft#5349 as ddbf2a6f8, rebasing Snapcraft onto craft-application 5 and restoring .snapcraft.yaml project detection for core24. | |
| #4679 refactor(docs): use more docs from craft-parts | snapcraft | merged | Merged #4679 as b8c9a17dc, replacing duplicated Snapcraft docs with direct craft-parts TOC references or includes for shared content. | |
| #5239 refactor: use craft-application's remote-build | snapcraft | merged | Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044. | |
| #6432 refactor: use humanize_list from craft-application | snapcraft | closed | Merged #6432 via commit 87c89a9b9, replacing Snapcraft’s local humanize_list with craft-application’s implementation after ty 0.0.83 complaints. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged PR #521 as de242431, migrating image and package services to craft-application 2.3.0's build plan without changing build semantics. | |
| #4659 fix: update to craft-application latest | snapcraft | merged | Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651. | |
| #4797 refactor: change PackCommand parent | snapcraft | merged | PR #4797 merged as commit b6f464c78, reparenting snapcraft's PackCommand onto craft-application's PackCommand, deleting ~23 lines of duplicated code enabled by craft-application#340/#341. | |
| #2734 SnapcraftError refactoring | snapcraft | merged | SnapcraftError refactoring was merged in canonical/snapcraft#2734 after maintainer approval, updating four files (+279/-26). | |
| #353 refactor(cli): add scaffolding for craft-application | rockcraft | merged | PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback. | |
| #4573 build(deps): use craft-application from main branch | snapcraft | merged | Merged PR #4573 as commit 1366effa9, updating Snapcraft to use craft-application from its main branch. |