← Back to issue list

Migrate snapcraft_legacy store commands

View original Github issue

Metadata

Project
snapcraft
Number
#5338
Type
issue
State
closed
Author
mr-cal
Labels
Status: Triaged Type: Refactor
Created
Updated
Closed

Current evaluation

All four legacy store commands were migrated through merged PRs #6109, #6128, #6207, and #6218; snapcraft_legacy was later removed.

Resolution: closed resolved

Reason: The migrations were merged as bab4cbf1a (#6109), acae2c953 (#6128), 98bb42c3b (#6207), and 4012735f6 (#6218), covering upload-metadata, set-default-track, metrics, and promote.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Migrate the following commands to modern Snapcraft code. * These commands use `snapcraft_legacy.store_api.StoreClient` * Use the publisher gateway if possible, otherwise they will need to be implemented in snapcraft's store service - [x] `snapcraft upload-metadata` (#6109) - [ ] `snapcraft promote` - [x] `snapcraft set-default-track` (https://github.com/canonical/snapcraft/pull/6128) - [ ] `snapcraft metrics` ### Why it needs to get done To use a modern craft-store client

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved All four legacy store commands were migrated through merged PRs #6109, #6128, #6207, and #6218; snapcraft_legacy was later removed.
stealth/space-bunny-alpha — closed resolved Migrated all four legacy store commands via merged PRs #6109 (bab4cbf1a), #6128 (acae2c953), #6207 (98bb42c3b), and #6218 (4012735f6).
stealth/space-bunny-alpha — closed resolved Tracking issue for migrating legacy store commands off snapcraft_legacy.StoreClient. All four landed: PR #6109 (bab4cbf1a), #6128 (acae2c953), #6207 metrics (98bb42c3b), #6218 promote (4012735f6); closed by maintainer.
stealth/space-bunny-alpha — closed resolved All four legacy store commands were migrated through merged PRs #6109, #6128, #6207, and #6218 (bab4cbf1a, acae2c953, 98bb42c3b, 4012735f6).
stealth/space-bunny-alpha — closed resolved Closed as partially resolved: PRs #6109 and #6128 migrated upload-metadata and set-default-track; promote and metrics were deferred to separate PRs #6218 and #6207.
qwen/qwen3.6-35b-a3b — — Partially completed. Migrated upload-metadata and set-default-track to modern snapcraft code. Promote and metrics commands deferred to a separate effort. Issue closed.
qwen/qwen3.6-35b-a3b — — Migrated upload-metadata and set-default-track commands to modern snapcraft code. The issue is closed as completed, with promote and metrics deferred to a separate migration effort.
qwen3.6-35b-a3b-mtp-q6 — — Closed as completed after merging PRs #6109 and #6128, which migrated upload-metadata and set-default-track to modern Snapcraft. promote and metrics deferred to a separate effort.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#5339 Migrate snapcraft_legacy store assertion commands snapcraft closed Umbrella refactor issue for moving legacy store assertion commands to craft-store was rejected by mr-cal (each command should be its own task); only list-validation-sets was done via merged PR #6050 (commit ddfd7b58b).
78%
#5982 Trim down snapcraft_legacy and plan migration effort snapcraft closed Superseded by a revised plan to migrate store commands first, then delete snapcraft_legacy; the package was later removed in ffb164b7a and 995f0a3bc.
77%
#1284 Migrate store commands to craft-application charmcraft closed Store commands were migrated to craft-application in merged PR #1358 (commit 5cb01186); commit 9da46c37 later removed the unused legacy implementations.
77%
#4194 Migrate snapcraft_legacy subcommands to use craft-cli snapcraft closed Requested legacy-handler bypass was abandoned; verbosity support landed in #5646/#5680, and snapcraft_legacy was later removed in ffb164b7a.
77%
#1358 feat(craft-application): migrate store commands charmcraft merged Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations.
72%
#3063 cli: update command names to new design snapcraft merged Merged in snapcraft#3063 (2efd78de3), adopting new command names while retaining deprecated legacy commands and removing redundant store CLI tests.
71%
#5744 Migrate legacy schema snapcraft closed Migrated the legacy schema to snapcraft-legacy.json and updated snapcraft_legacy to use the copy; merged in #5751 (cf2ecd9dc).
70%