refactor: migrate promote command
Metadata
Current evaluation
Merged the promote command migration from snapcraft_legacy into the main codebase in commit 4012735f6, preserving legacy behavior.
Resolution: closed resolved
Reason: PR #6218 was merged into main as commit 4012735f6, completing SNAPCRAFT-1316 with a near-verbatim migration of the promote command.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Migrates the `promote` command from snapcraft_legacy.
I would have loved to do more refactoring and integrate this with the existing classes, but this command is complex and there are too many subtle behaviors and corner cases baked into the legacy code. So I kept this is as near-verbatim migration.
(SNAPCRAFT-1316)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged the promote command migration from snapcraft_legacy into the main codebase in commit 4012735f6, preserving legacy behavior. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #6218 in commit 4012735f6, moving promote from snapcraft_legacy to the main codebase as a near-verbatim migration. | |
| qwen/qwen3.6-35b-a3b | — | — | Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a near-verbatim migration of the promote command from snapcraft_legacy to preserve complex legacy behaviors and corner cases. Resolves SNAPCRAFT-1316. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6145 refactor: migrate gated command | snapcraft | merged | Merged PR #6145 as commit 21091b932, migrating the gated command from snapcraft_legacy and resolving SNAPCRAFT-1314. | |
| #6144 refactor: migrate keys | snapcraft | merged | PR #6144 merged the migration of the keys command out of snapcraft_legacy, completing SNAPCRAFT-1315 in commit 30c9fcd19. | |
| #6207 refactor: migrate metrics command | snapcraft | merged | Merged as commit 98bb42c3b, migrating the metrics command from Snapcraft’s legacy codebase to the new command architecture for SNAPCRAFT-1319. | |
| #5298 `promote` command specifies `-v` in help, but option does not exist | snapcraft | closed | The promote help/option mismatch was addressed by legacy-command work in #5423 and released in Snapcraft 8.11.1. | |
| #6141 refactor: migrate create-key command | snapcraft | merged | Merged the create-key command migration from snapcraft_legacy in squash commit a1a0fb103, adding the command to the new Snapcraft command framework. |