← Back to issue list

Migrate snapcraft_legacy store assertion commands

View original Github issue

Metadata

Project
snapcraft
Number
#5339
Type
issue
State
closed
Author
mr-cal
Labels
Status: Triaged Type: Refactor
Created
Updated
Closed

Current evaluation

Umbrella refactor issue for moving legacy store assertion commands to craft-store was rejected by mr-cal (each command should be its own task); only list-validation-sets was done via merged PR #6050 (commit ddfd7b58b).

Resolution: closed superseded

Reason: Maintainer mr-cal closed the tracking issue with the comment "Rejecting because each command should be it's own task." The only completed item, list-validation-sets, was delivered separately in merged PR #6050 (ddfd7b58b), which fixed #5337; the remaining commands (list-keys, create-key, register-key, sign-build, validate, gated) were to be tracked individually.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done Migrate the following store assertion commands to modern Snapcraft code. * These commands use `snapcraft_legacy.store_api.StoreClient` * Use the publisher gateway if possible, otherwise they will need to be implemented in snapcraft's store service - [ ] `snapcraft list-keys` - [ ] `snapcraft create-key` - [ ] `snapcraft register-key` - [ ] `snapcraft sign-build` - [ ] `snapcraft validate` - [ ] `snapcraft gated` - [x] `snapcraft list-validation-sets` (https://github.com/canonical/snapcraft/pull/6050) ### Why it needs to get done To use a modern craft-store client

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Umbrella refactor issue for moving legacy store assertion commands to craft-store was rejected by mr-cal (each command should be its own task); only list-validation-sets was done via merged PR #6050 (commit ddfd7b58b).
stealth/space-bunny-alpha — closed stale Rejected the umbrella migration request because each command should be tracked separately; no code change addressed the remaining commands. PR #6050 had already completed list-validation-sets.
qwen/qwen3.6-35b-a3b — — Rejected because each command requires separate tracking. The list-validation-sets command was migrated via PR 6050. Remaining commands need individual tasks.
qwen/qwen3.6-35b-a3b — — Migrating legacy store assertion commands was rejected and closed. The maintainer directed that each command be tracked as a separate task. One command, list-validation-sets, was already implemented via PR #6050.
qwen3.6-35b-a3b-mtp-q6 — — Rejected as a single issue since each command requires separate tracking. The list-validation-sets command was completed via PR #6050. Remaining commands will be migrated individually as new tasks.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#6050 (confidence 70%)

    Merged PR cited in the issue checklist; migrated list-validation-sets to a service (commit ddfd7b58b)

  • Related To: canonical/snapcraft#5337 (confidence 55%)

    Per-command validation-sets issue fixed by PR #6050, illustrating the split-into-separate-tasks approach

Related issues

Issue Project State Summary Similarity
#5338 Migrate snapcraft_legacy store commands snapcraft closed All four legacy store commands were migrated through merged PRs #6109, #6128, #6207, and #6218; snapcraft_legacy was later removed.
78%
#1284 Migrate store commands to craft-application charmcraft closed Store commands were migrated to craft-application in merged PR #1358 (commit 5cb01186); commit 9da46c37 later removed the unused legacy implementations.
74%
#1358 feat(craft-application): migrate store commands charmcraft merged Merged PR #1358 migrated Charmcraft store commands to craft-application, completing #1284; 5cb01186 contains the mechanical migration, and 9da46c37 later removed legacy implementations.
72%