← Back to issue list

fix: get the project from the project service every time

View original Github issue

Metadata

Project
snapcraft
Number
#5748
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix ensuring the project is retrieved from the project service on every call. Approved by two reviewers, the change modifies one file (+9/-1 lines) and resolves the retrieval logic despite one failing CI test.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix ensuring the project is retrieved from the project service on every call. Approved by two reviewers, the change modifies one file (+9/-1 lines) and resolves the retrieval logic despite one failing CI test.
qwen3.6-35b-a3b-mtp-q6 Merged a fix that retrieves the project from the project service on every call. Linting and tests passed prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged a fix ensuring the project is retrieved from the project service on every call. The maintainer-submitted change passed linting and testing checks and was integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#153 fix: un-deprecate project attribute craft-application merged Merged a fix un-deprecating the project attribute. Approved by two reviewers with passing CI checks and maintained test coverage. The change modified two files, removing 47 lines and adding 3.
75%
#2681 fix: correctly get project name for remote builds charmcraft merged Merged after three approvals. Corrects project name retrieval for remote builds, resolving #2598. Integrated despite non-blocking type-checking warnings and two unresolved review comments.
74%
#276 fix: show better error when project file is missing craft-application merged Merged a fix improving error messaging when a project file is missing. Approved by three reviewers, the change updates three files to provide clearer feedback during missing file scenarios.
74%
#2419 project: state file path change snapcraft merged Merged a change updating the project state file path. Approved by one reviewer, passed CI checks, and integrated into the codebase with 24 additions and 25 deletions across six files.
74%
#244 fix: handle multiple types of Launchpad error when getting projects craft-application merged Merged a fix that handles multiple types of Launchpad errors when retrieving projects. Approved by two reviewers, passed CI checks, and applied minimal changes (+2/-2 lines in one file.)
73%
#64 fix: remove compulsory need for project on service configuration craft-application merged Merged fix removing the compulsory project requirement from service configuration, enabling non-lifecycle commands. Approved by two reviewers, passed CI, and merged into main as a workaround for issue #63.
72%
#686 fix(ProjectService): better handling for invalid platforms craft-application merged Merged fix improving ProjectService invalid platform handling. Approved by two reviewers, passes CI, and updates the changelog. Incorporates targeted commits addressing review feedback from PR #683 across five files.
72%
#684 perf: cache project file path craft-application merged Merged a performance optimization caching the project file path. Approved by two reviewers, passed CI, and changed one line. The author kept the perf commit type as it improves efficiency rather than fixing a bug.
71%
#725 fix!(services/project): use project generation error craft-application merged Merged change replacing a generic runtime error with a specific project generation error during prime project configuration. Resolves #705. Approved by three reviewers and passed all CI checks.
71%
#1367 fix: make application handle a nonexistent project dir charmcraft merged Merged a fix enabling the application to handle nonexistent project directories. Approved by two reviewers and dependent on PR #1364. Changes span 35 files with 989 additions and 252 deletions.
71%