← Back to issue list

Remove all snapcraftctl code and compatibility wrapper for core22

View original Github issue

Metadata

Project
snapcraft
Number
#5774
Type
pull request
State
closed
Author
Nalin-Kumar-Gupta
Labels
—
Created
Updated
Closed

Current evaluation

PR to strip snapcraftctl code for core22 was closed unmerged: maintainers (mr-cal) said removal can't happen for core22/core24 as it would break existing builds, so the wrapper was kept. Later #5983 (eaadefa01) errors on snapcraftctl only in core26.

Resolution: closed not a bug

Reason: Closed by maintainer mr-cal with the decision not to remove snapcraftctl for core22 and core24 because it would break existing builds, and issue #5754 was closed alongside. The compatibility wrapper (craftctl) therefore remains in place for those bases.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR removes all code related to snapcraftctl in core22, as snapcraftctl has been deprecated in favor of craftctl. Fixes (#5754) ### Changes Made: - Remove snapcraftctl CLI module and related code - Delete legacy test cases testing snapcraftctl functionality - Update schema defaults from `snapcraftctl` to `craftctl default` - Update plugin documentation to reference `craftctl` - Update error messages to use `craftctl set version` - Clean up remaining snapcraftctl variables and references ### What's Preserved: - Documentation explaining the migration from snapcraftctl to craftctl - Test files for older bases (core20, core) where snapcraftctl is still supported Resolves the core22 deprecation of snapcraftctl in favor of craftctl. --- - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed not a bug PR to strip snapcraftctl code for core22 was closed unmerged: maintainers (mr-cal) said removal can't happen for core22/core24 as it would break existing builds, so the wrapper was kept. Later #5983 (eaadefa01) errors on snapcraftctl only in core26.
stealth/space-bunny-alpha — closed stale Removal was rejected and closed to avoid breaking existing core22 and core24 builds; the snapcraftctl compatibility wrapper was retained.
qwen/qwen3.6-35b-a3b — — Maintainers closed the proposed removal of deprecated snapcraftctl code for core22 and core24 without merging. The change was rejected to prevent breaking existing builds.
qwen3.6-35b-a3b-mtp-q6 — — Closed and rejected. Maintainers decided against removing snapcraftctl for core22 and core24 to prevent breaking existing builds. Related issue #5754 was also closed.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5754 (confidence 95%)

    Parent issue that the PR claimed to fix; closed together with it, wrapper retained for core22/core24.

  • Superseded By: canonical/snapcraft#5983 (confidence 80%)

    Merged as eaadefa01 'feat!: error on snapcraftctl' — implements the alternative approach from #5782, erroring on snapcraftctl only in core26 override scripts.

  • Related To: canonical/snapcraft#5782 (confidence 80%)

    Follow-up issue opened during review for project-model validation of snapcraftctl; shipped for core26 via #5983.

Related issues

Issue Project State Summary Similarity
#5754 Remove the `snapcraftctl` compatibility wrapper snapcraft closed Closed as won't-fix by mr-cal: snapcraftctl wrapper must stay for core22/core24 to avoid breaking existing builds. Implementation PR #5774 was closed unmerged; #5983 (eaadefa01) only makes core26 error on snapcraftctl.
91%
#3751 craftctl: add snapcraftctl compatibility wrapper snapcraft merged Merged #3751 added a snapcraftctl compatibility wrapper delegating to craftctl, prompted core22 users to migrate, and restored execution of existing spread tests.
77%
#6450 fix(test): error for core22 snaps snapcraft closed PR #6450 proposed an early core22 error for snapcraft test, but was closed unmerged with review pending; #5479 remains open.
74%
#6336 Snapcraft 9: snapcraftctl errors in core22 snaps snapcraft closed Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336.
74%
#4186 snap: migrate to core22 snapcraft merged PR #4186 merged, moving the Snapcraft snap's own build environment to base core22 (8 files, +71/-70), landing as commit 60033305b and closing the core22 migration issue #4166.
74%
#4166 Migrate Snapcraft to core22 snapcraft closed Snapcraft's own snap was migrated to base core22 by merged PR #4186 (commit 60033305b, 8 files, +71/-70), closing this tracking issue.
73%
#4177 core18: removal snapcraft merged Merged PR snapcore/snapcraft#4177 (May 2023) dropped core18 base support and its unit/spread tests, fixing #4165 via commits 40136ea9b, 77edc734b and ed423b6a8; core18 was EOL.
72%
#5983 feat!: error on snapcraftctl snapcraft merged Merged #5983 as eaadefa01: snapcraftctl now errors in core26+ override scripts, and related references were renamed to craftctl.
72%
#6009 test: remove core20 spread tests snapcraft merged Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675).
72%
#4165 Remove core18 from Snapcraft snapcraft closed Core18 support was removed by merged PR #4177 in commits 40136ea9b, 77edc734b, and ed423b6a8; remaining electron-builder cleanup was tracked in #4182.
71%