chore: remove unused set_legacy_env
Metadata
Current evaluation
Closed unmerged; author superseded it by reworking branch layout to work/refactor/* and pushing directly to canonical/snapcraft.
Resolution: closed superseded
Reason: Author @lengau commented on 2026-10-06: 'Superseded: reworking the branch layout to work/refactor/* and pushing directly to canonical/snapcraft.' No merge or resolving commit was found.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`set_legacy_env` in `snapcraft/store/_legacy_account.py` has no callers.
It rewrote `ENVIRONMENT_STORE_CREDENTIALS` from the legacy configparser format into a base64 auth header at startup. That responsibility now lives in `get_client()` in `snapcraft/store/client.py`, which builds a `LegacyUbuntuOne` client when `has_legacy_credentials()` or `env_has_legacy_credentials()` is true.
Both helper methods stay, since `get_client()` and `LegacyUbuntuOne.__init__` still use them.
No behaviour change.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed superseded | Closed unmerged; author superseded it by reworking branch layout to work/refactor/* and pushing directly to canonical/snapcraft. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6469 chore: remove unused _read_config | snapcraft | closed | Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*. | |
| #6470 chore: remove unused errors | snapcraft | closed | PR removing unused SnapcraftError subclasses was closed unmerged; superseded by reworking the branch layout and pushing directly to canonical/snapcraft. | |
| #6241 chore: remove snapcraft_legacy | snapcraft | merged | Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed. | |
| #6476 chore: remove unused set_legacy_env | snapcraft | open | Removes unused set_legacy_env from snapcraft/store/_legacy_account.py; legacy credential conversion now handled by get_client() and LegacyUbuntuOne.__init__. Clean diff, CI green except pending integration tests. | |
| #5994 chore!: remove legacy remote builder | snapcraft | merged | Merged PR #5994 as b08f1a66e, removing the legacy remote builder and closing #5676 for Snapcraft 9.0. | |
| #5731 chore(legacy-cli): remove unused help.py and version.py, drop related test | snapcraft | closed | Closed unmerged as superseded by merged #5777, which combined this cleanup with #5773 and removed the unused legacy help/version commands, crediting both contributors. | |
| #5777 chore(legacy-cli): remove unused help and version commands | snapcraft | closed | Merged #5777, removing unused legacy CLI help/version commands after confirming snapcraft_legacy was not exposed in official releases; it combined #5731 and #5773. | |
| #6035 chore!: remove deprecated commands | snapcraft | merged | Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196). | |
| #5821 chore(legacy): remove script entry point | snapcraft | merged | Merged as f8cf41382, removing the obsolete legacy script entry point to resolve confusion raised in #5778. | |
| #5183 chore(merge): 8.5.1 into main | snapcraft | merged | Merged Snapcraft 8.5.1 into main via #5183 (merge commit bfb63fa79), after approval by two reviewers. |