← Back to issue list

refactor: migrate gated command

View original Github issue

Metadata

Project
snapcraft
Number
#6145
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged the refactoring that migrates the gated command from snapcraft_legacy. Approved by two reviewers and passed most CI checks. Resolves SNAPCRAFT-1314.

Suggested action: —

No scores available.

Issue body

Migrates the `gated` command from `snapcraft_legacy`. (SNAPCRAFT-1314) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged the refactoring that migrates the gated command from snapcraft_legacy. Approved by two reviewers and passed most CI checks. Resolves SNAPCRAFT-1314.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the gated command from snapcraft_legacy. The pull request was merged after passing lint and test checks, resolving SNAPCRAFT-1314.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the gated command from snapcraft_legacy. Successfully merged after passing lint and test checks, resolving SNAPCRAFT-1314.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6218 refactor: migrate promote command snapcraft merged Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure.
80%
#6228 refactor: migrate sign-build command snapcraft merged Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR.
79%
#6144 refactor: migrate keys snapcraft merged Squash merged the migration of the keys command from snapcraft_legacy. Approved by two reviewers, the change modified 12 files with a net reduction of 157 lines. Resolves SNAPCRAFT-1315.
78%
#6208 refactor: migrate validate command snapcraft merged Merged via squash. Refactored the gated command and migrated the validate command from legacy to modern Snapcraft, implementing a new Pydantic model for validation assertions across 21 files.
76%
#6141 refactor: migrate create-key command snapcraft merged Merged after approval. The create-key command was successfully migrated from snapcraft_legacy. Integration test failures were dismissed as unrelated by the author, and the PR was squash merged.
75%
#4830 refactor: migrate commands to craft-application snapcraft merged Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742.
75%
#813 "snapcraft validate" and "snapcraft gated" commands snapcraft merged Merged implementation of snapcraft validate and gated commands. Contributor ralsina added 706 lines across 14 files, addressed reviewer feedback, and discussed CLI parsing alternatives. Approved and merged by maintainers.
72%
#6207 refactor: migrate metrics command snapcraft merged Merged the refactor migrating the metrics command from the legacy codebase to the new implementation. The change modified 21 files, adding 683 lines and removing 1002, resolving SNAPCRAFT-1319 after successful review and CI validation.
71%