← Back to issue list

refactor: migrate keys

View original Github issue

Metadata

Project
snapcraft
Number
#6144
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Squash merged the migration of the keys command from snapcraft_legacy. Approved by two reviewers, the change modified 12 files with a net reduction of 157 lines. Resolves SNAPCRAFT-1315.

Suggested action:

No scores available.

Issue body

Migrates the `keys` command from `snapcraft_legacy`. (SNAPCRAFT-1315) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Squash merged the migration of the keys command from snapcraft_legacy. Approved by two reviewers, the change modified 12 files with a net reduction of 157 lines. Resolves SNAPCRAFT-1315.
qwen3.6-35b-a3b-mtp-q6 Squash merged the keys command migration from snapcraft_legacy. Maintainer mr-cal resolved SNAPCRAFT-1315 after passing all lint and test checks.
qwen3.6-35b-a3b-mtp-q6 Merged via squash by mr-cal, migrating the keys command from snapcraft_legacy to resolve SNAPCRAFT-1315. All lint and test checks passed, and the change was integrated without comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6141 refactor: migrate create-key command snapcraft merged Merged after approval. The create-key command was successfully migrated from snapcraft_legacy. Integration test failures were dismissed as unrelated by the author, and the PR was squash merged.
82%
#6145 refactor: migrate gated command snapcraft merged Merged the refactoring that migrates the gated command from snapcraft_legacy. Approved by two reviewers and passed most CI checks. Resolves SNAPCRAFT-1314.
78%
#6207 refactor: migrate metrics command snapcraft merged Merged the refactor migrating the metrics command from the legacy codebase to the new implementation. The change modified 21 files, adding 683 lines and removing 1002, resolving SNAPCRAFT-1319 after successful review and CI validation.
75%
#6218 refactor: migrate promote command snapcraft merged Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure.
73%
#6228 refactor: migrate sign-build command snapcraft merged Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR.
71%