← Back to issue list

refactor: migrate create-key command

View original Github issue

Metadata

Project
snapcraft
Number
#6141
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged after approval. The create-key command was successfully migrated from snapcraft_legacy. Integration test failures were dismissed as unrelated by the author, and the PR was squash merged.

Suggested action:

No scores available.

Issue body

Migrates the `create-key` command from `snapcraft_legacy`. (SNAPCRAFT-1313) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. The create-key command was successfully migrated from snapcraft_legacy. Integration test failures were dismissed as unrelated by the author, and the PR was squash merged.
qwen3.6-35b-a3b-mtp-q6 Squash merged the migration of the create-key command from snapcraft_legacy. Unrelated spread failures were addressed prior to merge. Authored by maintainer mr-cal.
qwen3.6-35b-a3b-mtp-q6 Squash merged the migration of the create-key command from snapcraft_legacy. Final comments noted unrelated spread failures prior to closure.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6144 refactor: migrate keys snapcraft merged Squash merged the migration of the keys command from snapcraft_legacy. Approved by two reviewers, the change modified 12 files with a net reduction of 157 lines. Resolves SNAPCRAFT-1315.
82%
#6145 refactor: migrate gated command snapcraft merged Merged the refactoring that migrates the gated command from snapcraft_legacy. Approved by two reviewers and passed most CI checks. Resolves SNAPCRAFT-1314.
75%
#6218 refactor: migrate promote command snapcraft merged Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure.
75%
#6228 refactor: migrate sign-build command snapcraft merged Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR.
71%