test: fix spread tests
Metadata
Current evaluation
Merged after fixing non-store spread tests and the OSV scanner. Pinned black to 26.3.1 to resolve patchelf segfaults and silent failures. Approved by two reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
Fixes all the non-store spread tests and the OSV scanner.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after fixing non-store spread tests and the OSV scanner. Pinned black to 26.3.1 to resolve patchelf segfaults and silent failures. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
0
Complexity:
10
Confidence:
90
|
needs review | Fixes several spread test failures. Opened by a maintainer, currently awaiting CI validation and initial review. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines). | |
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #2417 fix: fix a series of breaking spread tests | charmcraft | merged | Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation. | |
| #1460 fix(tests): make store spread tests less flaky | charmcraft | merged | Merged following approval by two reviewers and successful CI checks. The change resolves issue #1429 by adjusting two files to reduce flakiness in store spread tests, with a net diff of +7/-4 lines. | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. | |
| #3247 spread tests: fix classic patchelf linker regex to match all arches | snapcraft | merged | Merged a fix to spread tests that broadened the patchelf linker regex from ld-linux to ld.*. This ensures compatibility with architectures like ppc64el using alternative linker names. Approved by reviewer and passed CI checks. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #145 fix: fix tests on arm64 | craft-archives | merged | Merged to fix arm64 test failures. Approved by two reviewers and integrated after passing most CI checks, despite a failing OSV-scanner. Resolves #143 and #144 with a 32-line change across two files. |