tests: migrate legacy classic patchelf tests to spread
Metadata
Current evaluation
Merged after reviewer approval and passing CI. The change migrated legacy classic patchelf tests to the spread framework, updating 13 files with a net reduction of 186 lines.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change migrated legacy classic patchelf tests to the spread framework, updating 13 files with a net reduction of 186 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of legacy classic patchelf tests to the spread testing framework. Maintainer cjp256 integrated the changes into the main branch, updating the test suite without additional comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Migrated legacy classic patchelf tests to the spread testing framework. The pull request was successfully merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3247 spread tests: fix classic patchelf linker regex to match all arches | snapcraft | merged | Merged a fix to spread tests that broadened the patchelf linker regex from ld-linux to ld.*. This ensures compatibility with architectures like ppc64el using alternative linker names. Approved by reviewer and passed CI checks. | |
| #2276 spread: move legacy wiki tests to spread | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated legacy wiki tests from integration tests to spread, updating 12 files with a net reduction of 42 lines. Addresses LP: #1792717. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines). | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #4269 spread: add a test for the "python + classic" tutorial | snapcraft | merged | Merged into hotfix/7.5 after two approvals and passing CI. Introduces a spread test verifying the python classic confinement tutorial and patchelf fix on Ubuntu 20.04. The test passed successfully. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #2533 tests: classic confinement spread tests for ant and maven | snapcraft | merged | Merged after approval. Added spread tests for classic confinement covering ant and maven. Despite a Codecov warning about missing base commit coverage, the changes (+113/-9 lines across 7 files) were successfully integrated. |