tests: migrate legacy classic patchelf tests to spread
Metadata
Current evaluation
Merged PR #3242 as e76a07747, migrating legacy classic patchelf tests to Spread and removing 186 net lines across 13 files.
Resolution: closed resolved
Reason: The approved PR was merged as commit e76a07747, completing the migration of legacy classic patchelf coverage to Spread.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3242 as e76a07747, migrating legacy classic patchelf tests to Spread and removing 186 net lines across 13 files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3242 (e76a0774), migrating legacy classic patchelf tests to Spread and reducing them by 186 lines across 13 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change migrated legacy classic patchelf tests to the spread framework, updating 13 files with a net reduction of 186 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of legacy classic patchelf tests to the spread testing framework. Maintainer cjp256 integrated the changes into the main branch, updating the test suite without additional comments. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#3247
(confidence 95%)
Merged follow-up commit 9a9eb18f6 broadened the migrated spread test's linker regex for non-x86 architectures.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3247 spread tests: fix classic patchelf linker regex to match all arches | snapcraft | merged | Merged in #3247 (commit 9a9eb18f6), broadening the classic Patchelf spread-test linker match from ld-linux to ld.* to detect loaders such as ppc64el's ld64.so.2. | |
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files). | |
| #6350 test: fix spread tests | snapcraft | merged | Merged PR #6350 as a18c7f485, fixing all non-store Spread tests and OSV scanning, including pinning Black 26.3.1 to avoid patchelf failures. | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%). | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files. | |
| #77 core22-8 spread tests fail on classic-patchelf test | snapcraft-rocks | closed | Fixed by merged PR #80, a core22-8 backport of #69 that enabled verbose output so Snapcraft messages appear in failing spread-test logs. | |
| #3662 tests: update spread url | snapcraft | merged | Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70. | |
| #3269 spread tests: remove references of core16 | snapcraft | merged | Merged PR #3269 via commit ab84886f2, removing core16 references from three spread-test files. | |
| #2276 spread: move legacy wiki tests to spread | snapcraft | merged | Merged PR #2276 as commit 806b0b0db, moving all non-fake-server legacy wiki tests from the general integration suite to Spread. | |
| #486 test(spread): clean up plugin prep/restore | imagecraft | merged | Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability. |