fix: fix a series of breaking spread tests
Metadata
Current evaluation
Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation.
Suggested action: —
No scores available.
Issue body
Each of these commits fixes one test, so I suggest reviewing commit by commit.
These tests are still known to be broken, but they don't block the core24 migration:
- tests/spread/smoketests/different-dir
- tests/spread/smoketests/reactive:stable
- tests/spread/smoketests/reactive:two
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged commits fixing multiple breaking spread tests. Three smoketests remain known to be broken but do not block the core24 migration. Changes were integrated after commit-by-commit review. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after fixing multiple breaking spread tests. Three tests remain broken but do not block the core24 migration. Changes were integrated following individual commit review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #6350 test: fix spread tests | snapcraft | merged | Merged after fixing non-store spread tests and the OSV scanner. Pinned black to 26.3.1 to resolve patchelf segfaults and silent failures. Approved by two reviewers and passed CI checks. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #1197 ci: temporarily disable externally broken spread tests | charmcraft | merged | Merged to temporarily disable broken spread tests, restoring CI. Breakage stems from third-party dependency issues. Tests will be re-enabled once upstream fixes land. Approved by one reviewer, modified 3 files. | |
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release. | |
| #2032 ci: fixes to several weekly spread tests | charmcraft | merged | Merged CI fixes for several weekly spread tests. Approved by two reviewers and passed all checks with minimal changes across three files. Addresses initial test failures as a starting point for broader improvements. | |
| #2763 fix(tests/spread): fix reactive spread tests | charmcraft | merged | Merged after resolving failing reactive spread tests. The changes split the test suite into legacy and resolute variants, switched to binary wheels to fix dependency resolution, and removed obsolete flags. Approved by reviewers and integrated. | |
| #926 test: address a couple of non-flaky spread failures | rockcraft | merged | Merged after two approvals and passing all CI checks. Resolves non-flaky spread test failures by updating test configurations across three files, eliminating consistent failures. | |
| #97 fix(test): fix spread tests on Fedora | snapcraft-rocks | merged | Merged fix for spread tests on Fedora by switching from the closed core18 docker branch to the default branch for Fedora 39 compatibility. Approved by one reviewer with all CI checks passing. |