fix: fix a series of breaking spread tests
Metadata
Current evaluation
Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
Resolution: closed resolved
Reason: PR #2417 was approved and merged as commit 3bee888e after commit-by-commit fixes. It resolved the targeted spread-test breakage, while different-dir and two reactive smoke tests were explicitly deferred as non-blocking.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Each of these commits fixes one test, so I suggest reviewing commit by commit.
These tests are still known to be broken, but they don't block the core24 migration:
- tests/spread/smoketests/different-dir
- tests/spread/smoketests/reactive:stable
- tests/spread/smoketests/reactive:two
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2417 as commit 3bee888e, fixing multiple breaking Spread tests and unblocking core24 migration; three reactive/different-dir tests remained broken but non-blocking. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR charmcraft#2417 (commit 3bee888e) fixed several breaking spread tests commit-by-commit, unblocking the core24 migration. Reactive smoke tests were finished off in #2426 (7c33dd1b); different-dir remains broken. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2417 fixed multiple breaking spread tests through separate commits, unblocking core24; the listed different-dir and reactive smoke tests remained broken but non-blocking. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged commits fixing multiple breaking spread tests. Three smoketests remain known to be broken but do not block the core24 migration. Changes were integrated after commit-by-commit review. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#2426
(confidence 90%)
Merged follow-up commit 7c33dd1b fixed a remaining reactive-charm spread test.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca. | |
| #4763 tests: remove core24 snap workarounds (#4761) | snapcraft | merged | Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass. | |
| #6350 test: fix spread tests | snapcraft | merged | Merged PR #6350 as a18c7f485, fixing all non-store Spread tests and OSV scanning, including pinning Black 26.3.1 to avoid patchelf failures. | |
| #4056 spread: core24 testing infra | snapcraft | merged | Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639). | |
| #97 fix(test): fix spread tests on Fedora | snapcraft-rocks | merged | Merged PR #97 switched Spread tests from the closed core18 Docker branch to the default branch, fixing them on Fedora 39. | |
| #54 Add basic spread tests | imagecraft | merged | PR #54 merged as e5eb5f4, adding amd64 and arm64 spread tests for 20.04/22.04/24.04 (commits 819603b, 514868e). Later fixed by #127 (cd43de1) for 20.04 failures. | |
| #6009 test: remove core20 spread tests | snapcraft | merged | Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675). | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26. | |
| #717 fix(test): minor test fixes | craft-application | merged | Merged PR #717 (commit 9f02b30f) switched spread tests to streaming output and adopted Spread's new reroot key, fixing #704 and #715. | |
| #127 Fix spread tests | imagecraft | merged | Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed. |