← Back to issue list

tests: fix content provider snap not found for core22

View original Github issue

Metadata

Project
snapcraft
Number
#3731
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #3731 merged via commit 7fbaf82d (topic 83e8991, merge 5edd183c) into snapcraft 7.0; adjusted spread-test expected error text so core22's differing 'content provider snap not found' message passes.

Resolution: closed resolved

Reason: The PR itself was merged (approved, codecov comment shows merge into snapcraft/7.0 branch). Commit 7fbaf82d7 'tests: fix content provider snap not found for core22' changed 3 files (+8/-8), updating spread test expectations for the core22-specific error message.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Snapcraft for core22 has a different error message compared to legacy, adjust expected result in spread test accordingly. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3731 merged via commit 7fbaf82d (topic 83e8991, merge 5edd183c) into snapcraft 7.0; adjusted spread-test expected error text so core22's differing 'content provider snap not found' message passes.
stealth/space-bunny-alpha — closed resolved Merged in #3731 via commit 5edd183c5, updating spread-test expectations to match core22's different error for missing content-provider snaps.
qwen/qwen3.6-35b-a3b — — Merged following reviewer approval and successful CI. Adjusted spread test expectations to match core22's distinct error message for missing content provider snaps. Modified three files, increasing test coverage by 0.08%.
qwen3.6-35b-a3b-mtp-q6 — — Merged test expectation update to align with core22's distinct error message for missing content provider snaps. Successfully integrated into the main branch, increasing overall test coverage by 0.08%.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft/7fbaf82d7 (confidence 92%)

    Commit 'tests: fix content provider snap not found for core22' appears in tests/spread history and corresponds to this PR's merge commit 5edd183c.

Related issues

Issue Project State Summary Similarity
#77 core22-8 spread tests fail on classic-patchelf test snapcraft-rocks closed Fixed by merged PR #80, a core22-8 backport of #69 that enabled verbose output so Snapcraft messages appear in failing spread-test logs.
74%
#6450 fix(test): error for core22 snaps snapcraft closed PR #6450 proposed an early core22 error for snapcraft test, but was closed unmerged with review pending; #5479 remains open.
74%
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass.
73%
#6009 test: remove core20 spread tests snapcraft merged Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675).
73%
#3877 tests: enable provider spread tests for core22 snapcraft merged Merged as commit 7612a3a87: renamed the spread test dir build-providers to providers and moved legacy-only tests into providers/legacy, enabling provider spread tests on core22 (CRAFT-1266). Prerequisite for #3875.
73%
#4761 tests: remove core24 snap workarounds snapcraft merged Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca.
72%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
71%
#386 tests: update testing to use craft-test fetch-service merged Merged #386 as commit 323b0e1, replacing direct Spread calls with snapcraft test and updating the test base to core24.
71%
#6336 Snapcraft 9: snapcraftctl errors in core22 snaps snapcraft closed Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336.
70%
#3733 providers: user core22 buildd snapcraft merged Merged into snapcraft/7.0 via cdacb020f (implementation e2aaf3464), switching core22 provider builds to the Ubuntu buildd image.
70%