chore: remove unused _read_config
Metadata
Current evaluation
Merged PR removing dead _read_config helper and unused pathlib import from snapcraft/commands/account.py; no behaviour change.
Resolution: closed resolved
Reason: PR #6473 was merged after approval, deleting the unused _read_config function and its now-unused pathlib import from snapcraft/commands/account.py.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`_read_config` in `snapcraft/commands/account.py` has no callers anywhere in the repo. It reads a login file from disk for a command that no longer exists, so it is dead code left behind when the deprecated store commands were removed.
This also drops the `pathlib` import, which was only used by that function.
No behaviour change.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Merged PR removing dead _read_config helper and unused pathlib import from snapcraft/commands/account.py; no behaviour change. | |
| ~deepseek/deepseek-pro-latest |
Impact:
5
Quick Win:
4
Complexity:
5
Confidence:
88
Actionability:
85
|
needs review | Removes dead _read_config helper and its now-unused pathlib import from snapcraft/commands/account.py; no callers remain, no behaviour change. Approved by one reviewer, awaiting merge. | |
| ~deepseek/deepseek-pro-latest |
Impact:
10
Quick Win:
8
Complexity:
5
Confidence:
92
Actionability:
85
|
needs review | Removes dead `_read_config` helper and its now-unused `pathlib` import from snapcraft/commands/account.py; no callers remain and no behaviour change. CI green except pending integration tests, awaiting review. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6469 chore: remove unused _read_config | snapcraft | closed | Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*. | |
| #6079 chore: delete unused file | snapcraft | merged | Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup. | |
| #6474 chore: remove unused errors | snapcraft | merged | Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change. | |
| #6035 chore!: remove deprecated commands | snapcraft | merged | Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196). | |
| #6241 chore: remove snapcraft_legacy | snapcraft | merged | Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed. | |
| #6476 chore: remove unused set_legacy_env | snapcraft | open | Removes unused set_legacy_env from snapcraft/store/_legacy_account.py; legacy credential conversion now handled by get_client() and LegacyUbuntuOne.__init__. Clean diff, CI green except pending integration tests. | |
| #6074 chore!: remove default command | snapcraft | merged | PR #6074 merged as db7c53f21, removing bare snapcraft packing for #5673; #6178 later reverted the change in e5aaf0683. |