← Back to issue list

chore: remove unused errors

View original Github issue

Metadata

Project
snapcraft
Number
#6474
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change.

Resolution: closed resolved

Reason: PR #6474 was approved and merged, removing unused error classes and a redundant comment with no behavior change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Removes three `SnapcraftError` subclasses that are never raised anywhere in the codebase: - `InvalidArchitecture` - `ArchAllInvalid` - `ProjectMissing` This also drops a stale comment in `snapcraft/services/init.py` that referred to `ProjectMissing`. That `except` clause was replaced with `craft_application.errors.ProjectFileError` in ddbf2a6f8, and the `ProjectFileError` branch already logs what it does, so the comment was redundant. No behaviour change.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 90
Actionability: 80
needs review Removes three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behaviour change. Approved, CI green except one ubuntu-22.04 integration test.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 90
Actionability: 80
needs review Removes three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in snapcraft/services/init.py; no behaviour change. Approved, one unrelated CI check failing.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 90
Actionability: 85
needs review Removes three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in snapcraft/services/init.py; no behaviour change. CI passing except pending integration-spread tests.
~deepseek/deepseek-pro-latest
Impact: 10
Quick Win: 8
Complexity: 5
Confidence: 92
Actionability: 85
needs review Removes three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py. No behaviour change; CI green, awaiting review.

Update history

Date Change
merged
updated
updated
created

Related issues

Issue Project State Summary Similarity
#6470 chore: remove unused errors snapcraft closed PR removing unused SnapcraftError subclasses was closed unmerged; superseded by reworking the branch layout and pushing directly to canonical/snapcraft.
83%
#1078 chore!: remove deprecated APIs craft-application merged Merged PR #1078 as 3334f13e, removing eight deprecated APIs and fixing #1063. All CI checks passed, with local Snapcraft verification.
80%
#6079 chore: delete unused file snapcraft merged Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup.
76%
#6035 chore!: remove deprecated commands snapcraft merged Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196).
76%
#6241 chore: remove snapcraft_legacy snapcraft merged Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed.
75%
#6469 chore: remove unused _read_config snapcraft closed Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*.
74%
#6473 chore: remove unused _read_config snapcraft merged Merged PR removing dead _read_config helper and unused pathlib import from snapcraft/commands/account.py; no behaviour change.
73%
#2682 chore: delete some dead code charmcraft merged Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.
72%
#794 chore: remove pydantic warnings craft-parts merged Merged as commit 5c1c7dd3, incorporating craft-archives PR #122 (commit 00b9b3b) to eliminate Pydantic deprecation warnings.
71%
#5183 chore(merge): 8.5.1 into main snapcraft merged Merged Snapcraft 8.5.1 into main via #5183 (merge commit bfb63fa79), after approval by two reviewers.
71%