← Back to issue list

sources: refactor git source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#964
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.

Suggested action:

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Git source into `sources/_git.py`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor extracting the Git source into a dedicated sources/_git.py module, advancing progress on Launchpad bug #1648906. Code coverage remained stable at 96.24% upon merge.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor extracting the Git source into a dedicated module at sources/_git.py. This change advances Launchpad bug #1648906 while maintaining code coverage above 96 percent.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#961 sources: refactor local source into module. snapcraft merged Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage.
75%
#965 sources: refactor mercurial source into module. snapcraft merged Merged into master after approval and passing CI. The change extracts the Mercurial source handler into a dedicated module, advancing work on bug LP: #1648906. Coverage increased slightly with no unresolved comments.
74%
#962 sources: refactor bazaar source into module. snapcraft merged Merged refactoring that extracts the Bazaar source handler into a dedicated module at sources/_bazaar.py. Approved, passed CI, and slightly improved code coverage as part of ongoing bug resolution.
74%
#233 added test for git sources in sources.py snapcraft merged Merged after adding tests for git sources in sources.py. Initial assertion fix request was dropped after clarifying the method needs no parameters. Coverage improved, approval granted, and changes merged.
74%
#957 sources: refactor base sources into module. snapcraft merged Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
72%
#968 sources: refactor subversion source into module. snapcraft merged Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files.
71%
#967 sources: refactor script source into module. snapcraft merged Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906.
71%