sources: refactor git source into module.
Metadata
Current evaluation
Merged PR #964 (commit f9ee3f034) by maintainer kyrofa, extracting the Git source handler out of sources.py into snapcraft/sources/_git.py as part of the sources refactor series for LP #1648906.
Resolution: closed resolved
Reason: The pull request itself was approved and merged to master as commit f9ee3f034 with a +236/-198 diff moving the Git source logic into sources/_git.py; the refactor tracked Launchpad bug #1648906.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #964 (commit f9ee3f034) by maintainer kyrofa, extracting the Git source handler out of sources.py into snapcraft/sources/_git.py as part of the sources refactor series for LP #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #964 as f9ee3f034, extracting Git source logic from sources.py into sources/_git.py as part of Launchpad bug #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #964 as commit f9ee3f034, extracting Git source logic from sources.py into sources/_git.py as part of LP #1648906. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #964, extracting Git source logic into sources/_git.py in commit f9ee3f034 to advance the Launchpad refactor. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a refactor extracting the Git source into a dedicated sources/_git.py module, advancing progress on Launchpad bug #1648906. Code coverage remained stable at 96.24% upon merge. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#963
(confidence 85%)
Sibling PR in the same sources-module refactor series (deb source into module), merged as 9aad0e3a5.
-
Related To:
snapcraft#965
(confidence 85%)
Sibling refactor of the mercurial source into its own module (e42bc812f), same LP #1648906 effort.
-
Related To:
snapcraft#970
(confidence 80%)
Later sibling PR completing the series (zip source into module, db2a6fb6a).
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #217 added test for git sources in the get() method in snapcraft/sources.py | snapcraft | closed | Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292. | |
| #955 sources: convert to package. | snapcraft | merged | Merged PR #955 (commit 0ef7dc218) converted snapcraft/internal/sources.py into a package, groundwork for LP bug #1648906. Follow-ups #957 and #961-#970 then split each source handler into its own module. | |
| #961 sources: refactor local source into module. | snapcraft | merged | Merged PR snapcore/snapcraft#961 by kyrofa extracted the Local source into sources/_local.py, merged as commit ec4b8f341. Part of the wider sources refactor series (#957, #962-#970) for LP #1648906. |