← Back to issue list

tests: fix integration tests in armhf

View original Github issue

Metadata

Project
snapcraft
Number
#971
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged to master after approval and passing CI. The patch fixes integration tests on armhf architecture. Reviewers approved the change but recommended using project_options over platform.machine for future architectural consistency. Code coverage remained stable at 96.39%.

Suggested action:

No scores available.

Issue body

LP: #1649899

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to master after approval and passing CI. The patch fixes integration tests on armhf architecture. Reviewers approved the change but recommended using project_options over platform.machine for future architectural consistency. Code coverage remained stable at 96.39%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, this change fixes armhf integration tests while maintaining full code coverage. Reviewers noted avoiding platform.machine in favor of project_options for future architecture detection in tests.
qwen3.6-35b-a3b-mtp-q6 Merged to master. Resolved armhf integration test failures by updating architecture detection. Reviewers recommended avoiding platform.machine in favor of project_options for future maintainability. Test coverage held at 96.39%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#990 tests: fix snaps tests in armhf snapcraft merged Merged into master to fix failing snap tests on the armhf architecture. Approved by a reviewer, the change updated 11 files and resolved CI failures without altering overall code coverage.
78%
#145 fix: fix tests on arm64 craft-archives merged Merged to fix arm64 test failures. Approved by two reviewers and integrated after passing most CI checks, despite a failing OSV-scanner. Resolves #143 and #144 with a 32-line change across two files.
76%
#1985 tests: document arm testing setup snapcraft merged Merged pull request documenting the ARM testing setup. The change adds 66 lines to a single file and was approved by two reviewers before integration.
74%
#945 Fix unittests in armhf snapcraft merged Merged fix for armhf unit tests. Updated 3 files with 33 additions and 16 deletions. Code coverage remained stable at 97.06% post-merge.
74%
#1292 tests: fix the recording tests to work in multiple architectures snapcraft merged Merged a four-line change that corrected recording tests for cross-architecture compatibility. Approved by one reviewer, the update caused zero coverage impact and was successfully integrated into the master branch.
73%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.
72%
#1040 Run the rust test in armhf snapcraft merged Merged to enable Rust tests on the armhf architecture. Approved by a maintainer, the update modifies two files and maintains 96.36% code coverage. Resolves launchpad bug #1655203.
72%
#1316 Run unit tests on Travis with mock armhf snapcraft merged Merged to enable Travis armhf unit tests by globally mocking platform.machine. This catches cross-architecture failures previously only visible in autopkgtest. Reviewers approved the testing enhancement despite minor implementation feedback.
72%
#1822 tests: skip classic confined tests on armhf snapcraft merged Merged. Skips classic confined tests on armhf architecture because a snapcraft deb requirement to install patchelf from the snapstore disabled them. Approved by one reviewer and merged with a +14/-6 change across seven files.
71%
#917 Fix unittests in armhf snapcraft closed Closed in favor of PR #945 to split integration and snaps tests into separate branches. Original changes addressed armhf unittest failures after test machine configuration updates.
71%