← Back to issue list

tests: fix integration tests in armhf

View original Github issue

Metadata

Project
snapcraft
Number
#971
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #971 as commit a725e69da, fixing armhf integration-test setup with architecture-specific test configuration.

Resolution: closed resolved

Reason: The approved change was merged into master as a725e69da and resolved LaunchPad bug #1649899 by fixing the armhf integration-test setup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1649899

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #971 as commit a725e69da, fixing armhf integration-test setup with architecture-specific test configuration.
stealth/space-bunny-alpha — closed resolved Merged PR #971 (commit a725e69da) fixed snapcraft's integration test suite on armhf, restoring the architecture-specific setup for LP bug #1649899. Approved by a reviewer, no unresolved comments.
stealth/space-bunny-alpha — closed resolved PR #971 merged into master as a725e69da, fixing integration-test setup for armhf. The maintainer-authored change was approved and landed without unresolved review comments.
stealth/space-bunny-alpha — closed resolved Merged into master in PR #971, fixing integration tests on armhf. The change was approved with no reported CI failures; reviewers suggested project_options instead of platform.machine for future architecture handling.
qwen/qwen3.6-35b-a3b — — Merged to master after approval and passing CI. The patch fixes integration tests on armhf architecture. Reviewers approved the change but recommended using project_options over platform.machine for future architectural consistency. Code coverage remained stable at 96.39%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, this change fixes armhf integration tests while maintaining full code coverage. Reviewers noted avoiding platform.machine in favor of project_options for future architecture detection in tests.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#917 Fix unittests in armhf snapcraft closed armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b.
79%
#1649899 integration tests fail in armhf snapcraft (launchpad) closed Armhf integration tests were fixed and re-enabled by merged PR snapcore/snapcraft#971 (commit a725e69da).
77%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged #1595 (8db14753d), fixing armhf snapd integration-test skips by checking self.deb_arch only after the parent setUp initialized it.
76%
#990 tests: fix snaps tests in armhf snapcraft merged Merged PR #990 as commit f467e55bc, correcting armhf failures in snap tests across 11 files and closing Launchpad bug #1650458.
76%
#145 fix: fix tests on arm64 craft-archives merged Merged as commit 8459563, fixing arm64 test expectations after prerequisite #143 and resolving #144.
75%
#921 ci: enable integration tests on arm64 craft-providers merged Merged PR #921 in commit 55b77b8 enabled basic and LXD integration tests on Ubuntu ARM runners, preparing CI for CRAFT-4990.
74%
#945 Fix unittests in armhf snapcraft merged Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf.
74%
#2520 fix: make integration tests work on ARM Mac runners charmcraft closed ARM-Mac test fixes were abandoned: PR #2520 closed unmerged, and commit f8b267e reverted the faulty changes after review.
74%
#1178 tests: make the kernel unit tests architecture independent. snapcraft merged Merged PR #1178 in commit b2a31b957, making kernel unit tests mock architecture so they behave consistently on ARM.
73%
#1985 tests: document arm testing setup snapcraft merged PR #1985 was merged, adding 66 lines to TESTING.md to document the ARM testing setup in commit 20411e8e2.
72%