← Back to issue list

go plugin: implement a go-packages plugin property

View original Github issue

Metadata

Project
snapcraft
Number
#99
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #99 added the go-packages property to Snapcraft's Go plugin in commit 657db2cf1, merged via 9d3d05044.

Resolution: closed resolved

Reason: The implementation was merged into the project after maintainer approval. Commit 657db2cf1 added the property, with merge commit 9d3d05044 recording its integration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #99 added the go-packages property to Snapcraft's Go plugin in commit 657db2cf1, merged via 9d3d05044.
stealth/space-bunny-alpha — closed resolved Merged PR #99 added a go-packages property to the Go plugin, updating three files (+100/-4) in commit 657db2cf1; merge commit: 9d3d05044.
qwen/qwen3.6-35b-a3b — — Successfully merged implementation of a go-packages plugin property for the Go plugin. Approved with a minor comment, the change extends plugin configuration by adding 100 lines across 3 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of a go-packages plugin property for the Go plugin. Approved by chipaca following a single minor comment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
75%
#733 Add the go-buildtags property to the go plugin snapcraft merged Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin, implementing LP #1609623 in commit 59d4acf8a.
75%
#78 plugins: add go plugin (CRAFT-48) craft-parts merged Merged into main as commit b5b779df (squash fa3fe8c8), adding craft_parts/plugins/go_plugin.py with GoPlugin, GoPluginProperties and GoPluginEnvironmentValidator, adapted from Snapcraft's V2 go plugin.
74%
#1609623 go plugin has no build tags snapcraft (launchpad) closed Added Go build-tag support via the go-buildtags property in snapcraft PR #733 (commit 59d4acf8a), later refined by PR #888.
71%
#2323 go plugin: support for bases snapcraft merged Merged PR #2323 (commit 45a993643): Go plugin revamped to prefer the go snap from the Snap Store and allow installing golang-go build-packages on supported bases, fixing LP: #1794785.
71%