Updated go plugin to use get_build_properties()
Metadata
Current evaluation
Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
Resolution: closed resolved
Reason: PR #997 updated go.py to use get_build_properties() instead of modifying the schema and added test_plugin_go.py coverage. The change landed in commit 0b4239ce7.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the go.py plugin to use the get_build_properties() methods instead of modifying the schema.
Updated the test_plugin_go.py file to add test.
https://github.com/snapcore/snapcraft/pull/997
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Go plugin was updated to use get_build_properties(), with test coverage added. PR #997 merged as 0b4239ce7. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes updating the go plugin to use get_build_properties() instead of modifying the schema, accompanied by new tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the Go plugin using get_build_properties() instead of schema modification, with corresponding test additions. Closed after integration. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged via pull request #997. The go plugin was updated to use get_build_properties() instead of modifying the schema, with corresponding test updates added to test_plugin_go.py. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#997
(confidence 100%)
Merged PR implementing the requested Go plugin change and tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #997 plugins: update go plugin to use get_build_properties() | snapcraft | merged | Merged PR #997 as commit 0b4239ce7, updating the Go plugin to use get_build_properties(), adjusting schema expectations, and adding helper unit tests. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #1650547 Update ant plugin to use get_build_properties | snapcraft (launchpad) | closed | Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. |