← Back to issue list

go plugin: support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2323
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2323 (commit 45a993643): Go plugin revamped to prefer the go snap from the Snap Store and allow installing golang-go build-packages on supported bases, fixing LP: #1794785.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft as commit 45a993643, making the Go plugin base-aware: it prefers the Store go snap and falls back to installing the golang-go deb on supported bases. The follow-up godeps plugin change (#2328, e1393815d) applied the same approach.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Revamp the go plugins installation candidates to prefer the go snap from the Snap Store first and provide a mechanism to be able to install a build-packages golang-go instead on the supported bases. LP: #1794785 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2323 (commit 45a993643): Go plugin revamped to prefer the go snap from the Snap Store and allow installing golang-go build-packages on supported bases, fixing LP: #1794785.
stealth/space-bunny-alpha — closed resolved Merged PR #2323 as 45a993643: the Go plugin now prefers the Go snap from the Snap Store and supports installing golang-go on supported bases.
stealth/space-bunny-alpha — closed resolved Merged PR #2323 added base support to the Go plugin, prioritizing the Go Snap Store snap and enabling golang-go as a build-package fallback; merged as commit 45a993643.
stealth/space-bunny-alpha — closed resolved Merged in #2323 (commit 45a993643), adding Go plugin base support: prefer the Go snap, with an option to install build-packages golang-go on supported bases.
qwen/qwen3.6-35b-a3b — — Merged. Introduces base support to the Go plugin, prioritizing the Go snap from the Snap Store and enabling golang-go installation on supported bases. Approved by reviewer and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Revamps the Go plugin to prioritize the Snap Store Go snap and enables golang-go installation via build-packages on supported bases, resolving LP #1794785.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2194 (confidence 90%)

    Earlier merged PR (12d9151d3) that made the Go plugin skip go debs when the go snap is used, the groundwork revamped here.

  • Related To: snapcraft#2328 (confidence 90%)

    Follow-up PR (e1393815d) applying the same bases support to the godeps plugin.

Related issues

Issue Project State Summary Similarity
#2328 godeps plugin: support for bases snapcraft merged Merged PR #2328 as commit e1393815d, adding base-aware godeps support that prefers the Go snap and can install golang-go as a build package.
85%
#1794785 Update the go plugin to be base aware snapcraft (launchpad) closed Base awareness for the Go plugin was implemented in snapcore/snapcraft#2323 and merged as commit 45a993643.
74%
#3046 plugins: introduce v2.GoPlugin snapcraft merged Merged as 7e14dd039, adding v2.GoPlugin for go.mod-based projects and making get_build_snaps an abstract PluginV2 method.
72%
#2372 gradle plugin: add support for bases snapcraft merged Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18.
72%
#2194 plugins: do not install go debs if go snap is used snapcraft merged Merged as commit 12d9151d3: the Go plugin now skips golang-go when a go build-snap is defined, preventing PATH conflicts.
71%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
71%
#99 go plugin: implement a go-packages plugin property snapcraft merged Merged PR #99 added the go-packages property to Snapcraft's Go plugin in commit 657db2cf1, merged via 9d3d05044.
71%
#1794784 Update the godeps plugin to be base aware snapcraft (launchpad) closed Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d.
70%