fix(make): depend on build deps during setup
Metadata
Current evaluation
Merged after reviewer approval and passing CI. The change updates the Makefile to correctly declare build dependencies during the setup phase, modifying a single line.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI. The change updates the Makefile to correctly declare build dependencies during the setup phase, modifying a single line. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to ensure Makefile dependencies are correctly resolved during the setup phase, preventing build failures caused by missing prerequisites. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #367 fix(build): install system packages when running `make setup` | craft-cli | merged | Merged a build fix installing system packages during make setup. Approved by two reviewers with all CI checks passing. The single-file change (+19/-10 lines) ensures build dependencies are correctly provisioned. | |
| #339 fix(make): generate a list of build dependencies and run one command | starbase | merged | Merged a Makefile fix that generates a build dependency list and executes a single command. Approved by one reviewer, the change adds 17 lines and removes 7 across one file. | |
| #418 fix: install system packages during setup | starbase | merged | Merged after approval and passing CI checks. The update configures make setup to run all setup targets, ensuring system packages are installed. A reviewer flagged potential dependency conflicts, but the changes were successfully integrated. | |
| #5645 fix: install system packages when running `make setup` | snapcraft | merged | Merged a fix updating make setup to install required system packages. Approved by two reviewers, passed CI, and merged by maintainer jahn-junior with a 19-line addition and 10-line removal across one file. | |
| #6133 build: fix docs-install target | snapcraft | merged | Merged a fix for the docs-install Makefile target that resolved redundant dependency installation. The change removes an extra uv sync call, ensuring docs targets work after make setup. Approved by reviewers and passed CI. | |
| #825 fix: install system packages when running `make setup` | craft-application | merged | Merged a fix updating make setup to install required system packages by cherry-picking Starbase commits. Approved by two reviewers with all CI checks passing, the single-file change resolves package installation issues during the build setup process. |