← Back to issue list

chore: explicitly use the 'check' command to avoid ruff warning about it

View original Github issue

Metadata

Project
charmcraft
Number
#1683
Type
pull request
State
merged
Author
tonyandrewmeyer
Labels
Created
Updated
Closed

Current evaluation

Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

Modern `ruff` requires explicitly saying `ruff check` for checks (since there's `format` now). Not doing this outputs a warning explaining that it should be done. This adjusts the templates to include `check` explicitly (both in lint and format).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged template updates to explicitly invoke the ruff check command, eliminating modern ruff deprecation warnings. Maintainer approved and merged the change.
qwen3.6-35b-a3b-mtp-q6 Merged template updates to explicitly invoke the ruff check command, resolving deprecation warnings from modern ruff versions. Approved and merged by maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#700 chore: update ruff craft-parts merged Merged after approval by two reviewers and passing CI checks. Updates ruff configuration across four files, supersedes #699, and resolves a lint issue addressed in #702.
82%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Merged after updating the ruff dependency and fixing new linting errors. Modifications were largely autoformatted across ten files. The changes received dual reviewer approval, passed CI checks, and were successfully integrated.
80%
#562 chore: use the non-legacy ruff check pre-commit hook starbase merged Merged to replace the deprecated ruff pre-commit hook with the non-legacy ruff-check hook. Approved by two reviewers, passed all CI checks, and committed with a single line change.
80%
#380 chore: update ruff pre-commit away from legacy craft-store merged Merged a minimal update replacing the legacy ruff pre-commit hook with the new ruff-check variant. Approved by reviewers and passing CI checks, the change successfully modernizes the project's linting configuration.
80%
#192 chore: update ruff settings starbase merged Merged updates to ruff configuration settings across two files. Approved by one reviewer, passed CI checks, and integrated into the main branch.
80%
#200 chore(deps): update ruff and its configuration craft-application merged Merged an update to ruff and its configuration. Approved by two reviewers with passing CI checks. The change modified one file with five additions and five deletions.
80%
#2442 chore: fix ruff warnings from test files charmcraft merged Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action.
79%
#363 chore: remove use of black in favor of ruff starbase merged Merged a maintainer's change removing dangling references to the black formatter and replacing it with ruff. Approved by two reviewers, passed CI, and modified one file with minimal changes.
78%
#115 chore(deps): update ruff and fix linting issue craft-application merged Merged into main after two approvals and passing CI. The update refreshed the ruff dependency and resolved a linting issue across two files. Codecov recorded a negligible 0.10% coverage decrease upon merge.
78%
#204 chore: use ruff snap starbase merged Merged "chore: use ruff snap". Approved by 3 reviewers and passed CI checks. Modified 4 files with a net diff of +5/-5 lines.
78%