chore: explicitly use the 'check' command to avoid ruff warning about it
Metadata
Current evaluation
PR #1683 merged as commit b48b8c59: charmcraft init templates now invoke `ruff check` explicitly in the tox lint and format envs, silencing the modern ruff deprecation warning.
Resolution: closed resolved
Reason: Merged into main as commit b48b8c59 ("chore: explicitly use the 'ruff check' command"), changing 3 template files (+6/-6) so lint and format invocations call `ruff check`; cmatsuoka approved 2024-05-27. The change is still present in the current templates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Modern `ruff` requires explicitly saying `ruff check` for checks (since there's `format` now). Not doing this outputs a warning explaining that it should be done.
This adjusts the templates to include `check` explicitly (both in lint and format).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1683 merged as commit b48b8c59: charmcraft init templates now invoke `ruff check` explicitly in the tox lint and format envs, silencing the modern ruff deprecation warning. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/charmcraft#1683 as commit b48b8c59, updating templates to explicitly run ruff check in lint and format, removing modern Ruff’s warning. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged an external contribution updating templates to explicitly use the ruff check command. This aligns with modern ruff syntax, eliminating deprecation warnings. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged template updates to explicitly invoke the ruff check command, eliminating modern ruff deprecation warnings. Maintainer approved and merged the change. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1941
(confidence 55%)
Later commit 9aba24c4 replaced flake8/pydocstyle with ruff in templates, building on the explicit `ruff check` usage.
-
Related To:
canonical/charmcraft#562
(confidence 40%)
Commit ba42dd9c applied the same `ruff check` idiom to the repo's own pre-commit hook.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #562 chore: use the non-legacy ruff check pre-commit hook | starbase | merged | PR #562 by maintainer lengau renamed the deprecated `ruff` pre-commit hook to `ruff-check` in .pre-commit-config.yaml (+1/-1 line). Merged to main as commit ba42dd9 with all CI checks passing. | |
| #380 chore: update ruff pre-commit away from legacy | craft-store | merged | Merged PR #380 (commit fc75854) replaced the legacy `ruff` pre-commit hook with the new `ruff-check` id in .pre-commit-config.yaml, a one-line lint config change approved by 2 reviewers. | |
| #230 chore(deps): update dependency lint/ruff to v0.1.15 | craft-cli | merged | Renovate PR merged (commit e68b0c7), bumping the ruff lint hook from 0.1.14 to 0.1.15 in .pre-commit-config.yaml; approved by two reviewers with no CI failures. | |
| #1576 chore: update ruff configs | charmcraft | merged | Merged Ruff configuration updates across seven files in canonical/charmcraft#1576, landing as commit 764ffba3 after approval by two maintainers. | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #715 chore(lint): use ruff from snap | craft-parts | merged | Merged PR canonical/craft-parts#715 (commit e0ecddb2, +3/-2 across 3 files): applied craft-cli#250 so linting installs ruff via `sudo snap install ruff` instead of a uv/pip dependency. | |
| #2442 chore: fix ruff warnings from test files | charmcraft | merged | PR #2442 merged (commit 8d54de9c): replaced deprecated Ruff-flagged constructs in five test files, clearing lint deprecation warnings. Only snap-store-tests failed, unrelated to the change. | |
| #246 chore(deps): update dependency lint/ruff to ~=0.3.5 | craft-cli | merged | Merged PR #246 updated lint/ruff from ~=0.2.1 to ~=0.3.5; the change landed on main in commit 6701822. | |
| #115 chore(deps): update dependency lint/ruff to v0.1.1 | craft-store | merged | Renovate PR #115 was merged, bumping lint/ruff from 0.1.0 to 0.1.1 in commit 1f36381. | |
| #578 chore(deps): update dependency lint/ruff to v0.4.10 | craft-providers | merged | Renovate PR merged: bumped the lint/ruff dependency from 0.4.8 to 0.4.10 (commit 117db56) after reviewer approval; a single-line version change. |