tests: check for submodules before running spread
Metadata
Current evaluation
Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications.
Suggested action: —
No scores available.
Issue body
Spread tests require the `snapd-testing-tools` submodule. If the submodule has not been fetched, then a useful error is provided.
Similar to https://github.com/snapcore/snapcraft/pull/4105, but perhaps simpler (I am open to feedback).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a check for the snapd-testing-tools submodule before running spread tests. It provides a clear error if missing, preventing cryptic failures and aligning with similar snapcraft improvements. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates that verify the snapd-testing-tools submodule exists before executing spread tests. The change adds a clear error message for missing submodules, replacing cryptic failures with actionable feedback. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully. | |
| #4105 tests: check for submodules before running spread | snapcraft | merged | Merged. Adds a pre-run check for the snapd-testing-tools submodule in spread tests to provide a clear error if missing. Approved by two reviewers, passed CI, and introduced no coverage changes. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | Merged to master, consolidating Autotools plugin and snapd tests into a single Spread suite to resolve Launchpad bug #1783825. The commit modifies six files, reduces code by 16 lines, passed CI checks, and received reviewer approval prior to integration. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #5389 test(spread): trace logs in spread tests | snapcraft | merged | Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts. | |
| #1029 fix(testing): error early if spread.yaml is invalid. | craft-application | merged | Merged after two approvals. Adds early validation to fail tests immediately if spread.yaml is invalid. CI passed except for an unrelated snap-test failure, which was overridden. | |
| #2793 tests: enable SNAPCRAFT_BUILD_INFO for spread | snapcraft | merged | Merged following approval and passing CI. Enabled SNAPCRAFT_BUILD_INFO for spread tests to cover manifest changes. Included a fix for the nil-basic spread test. Minimal diff across three files. | |
| #5845 test(spread): test building base and snapd snaps | snapcraft | merged | Merged spread tests for building base and snapd snaps. Despite initial CI failures linked to snapcraft issue #5843, the changes were approved and integrated to maintain build compatibility with mainline snapcraft. | |
| #3640 spread: update error when local snap is missing | snapcraft | merged | Merged a one-line change to improve error reporting when a local snap is missing during spread updates. Approved by a reviewer, passed CI, and integrated into the repository. |