tests: check for submodules before running spread
Metadata
Current evaluation
Merged PR #1084 as commit bc890e84, adding a preflight check that clearly reports when the snapd-testing-tools submodule is missing before Spread tests run.
Resolution: closed resolved
Reason: The approved PR was merged into main as commit bc890e84, adding the requested submodule validation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Spread tests require the `snapd-testing-tools` submodule. If the submodule has not been fetched, then a useful error is provided.
Similar to https://github.com/snapcore/snapcraft/pull/4105, but perhaps simpler (I am open to feedback).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1084 as commit bc890e84, adding a preflight check that clearly reports when the snapd-testing-tools submodule is missing before Spread tests run. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #240, adding a preflight check for snapd-testing-tools so spread tests fail with a clear error when the submodule is unfetched. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a check for the snapd-testing-tools submodule before running spread tests. It provides a clear error if missing, preventing cryptic failures and aligning with similar snapcraft improvements. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4105
(confidence 98%)
Referenced as a similar prior change for checking submodules before running Spread.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4105 tests: check for submodules before running spread | snapcraft | merged | Merged PR #4105 in commit 7921b04ed, adding a Spread preflight check that stops with a clear error when the snapd-testing-tools submodule is missing. | |
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825. | |
| #4006 docs: update HACKING.md to recurse submodules | snapcraft | merged | Merged PR #4006 in commit db9984a53, updating HACKING.md to clone with --recurse-submodules so snapd-testing-tools is available for Spread tests. | |
| #2183 tests: add spread suite for cmake plugin | snapcraft | merged | Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. |