← Back to issue list

docs: update HACKING.md to recurse submodules

View original Github issue

Metadata

Project
snapcraft
Number
#4006
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged documentation update to HACKING.md instructing developers to recurse into submodules for spread tests. Approved by one reviewer and merged by maintainer @mr-cal, who dismissed unrelated test failures.

Suggested action: —

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- A minor `HACKING.md` update requested by @giusebar. I recently added `snapd-testing-tools` as a submodule. This submodule is required for running spread tests, so now I've updated the hacking instructions.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged documentation update to HACKING.md instructing developers to recurse into submodules for spread tests. Approved by one reviewer and merged by maintainer @mr-cal, who dismissed unrelated test failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation update to HACKING.md to document recursing into submodules for spread tests. Maintainer approved and merged the change, dismissing unrelated core18 test failures. Code coverage increased by 0.61%.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation update to HACKING.md instructing developers to recurse into submodules for running spread tests. Maintainer approved and merged despite unrelated failing spread tests on core18.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#910 Update HACKING.md snapcraft merged Merged a documentation update to HACKING.md that removes an obsolete testing section and relocates it after dependency installation. The change was approved by a reviewer with a follow-up question.
79%
#791 docs: update CONTRIBUTING.md craft-application merged Merged after reviewer approval and passing CI checks. Updated CONTRIBUTING.md and removed HACKING.md.
77%
#162 docs(HACKING): update commit message guidelines starbase merged Merged updates to commit message guidelines in HACKING.rst for greater clarity. Approved by three reviewers, passed CI with 100% coverage, and modified three files. Minor commit type discussion did not block integration.
76%
#5578 docs: update CONTRIBUTING.md snapcraft merged Merged after approvals and passing CI. Updated CONTRIBUTING.md, removed HACKING.md, and reverted a redundant conf.py change. A reviewer noted a remaining README reference to HACKING.md requiring separate handling.
76%
#184 docs(HACKING): clarify commit header for merges starbase merged Merged a documentation update to the HACKING file to clarify commit header guidelines for merges. The change was approved by a reviewer and successfully integrated.
76%
#346 docs(HACKING): add note about revert commits starbase merged Merged documentation update to the HACKING guide. Added guidance on formatting revert commits using conventional commit standards. Approved by one reviewer, passed CI checks, and merged with a single line addition.
75%
#2568 docs: consolidate on a simple HACKING.md snapcraft merged Merged into master. Consolidates development setup and contribution guidelines into a single HACKING.md file for consistency and easier onboarding. Approved by a reviewer, passed CI checks, and integrated without impacting code coverage.
75%
#218 docs(HACKING): document branch names and changelog starbase merged Merged documentation updates to the HACKING file covering branch naming conventions and changelog procedures. Approved by two reviewers, the change adds 92 lines to a single file.
75%
#215 docs: add CONTRIBUTING.md imagecraft merged Merged into main, replacing HACKING.md with CONTRIBUTING.md. Approved by reviewers and passed all CI checks. Maintainer suggested future content trimming, but the documentation update was successfully integrated.
74%
#156 docs: update main project docs craft-cli merged Merged into main after approval. Restores HACKING.rst and updates README to reference it, preparing documentation for the 2.0.0 release. Code coverage unchanged.
72%