tests: check for submodules before running spread
Metadata
Current evaluation
Merged PR #4105 in commit 7921b04ed, adding a Spread preflight check that stops with a clear error when the snapd-testing-tools submodule is missing.
Resolution: closed resolved
Reason: PR #4105 was merged as commit 7921b04ed, adding a guard that checks for the required submodule before Spread runs.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [X] Have you successfully run `make lint`?
- [X] Have you successfully run `pytest tests/unit`?
-----
Spread tests require the `snapd-testing-tools` submodule. If the submodule has not been fetched, then a useful error is provided.
If approved, I'll make similar PR's for the other starcraft repos using spread.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4105 in commit 7921b04ed, adding a Spread preflight check that stops with a clear error when the snapd-testing-tools submodule is missing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4105 in commit 7921b04ed, adding a preflight check that prevents spread tests from running when the snapd-testing-tools submodule is missing. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds a pre-run check for the snapd-testing-tools submodule in spread tests to provide a clear error if missing. Approved by two reviewers, passed CI, and introduced no coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change that verifies the snapd-testing-tools submodule exists before running spread tests. The update provides a clear error message if the submodule is missing, preventing silent failures. Code coverage remains unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing. | |
| #1084 tests: check for submodules before running spread | charmcraft | merged | Merged PR #1084 as commit bc890e84, adding a preflight check that clearly reports when the snapd-testing-tools submodule is missing before Spread tests run. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #2937 spread tests: do not attempt to remove snapd snap | snapcraft | merged | Merged in commit b9290bb32; spread tests now skip removing the protected snapd snap, fixing LXD test failures. | |
| #4006 docs: update HACKING.md to recurse submodules | snapcraft | merged | Merged PR #4006 in commit db9984a53, updating HACKING.md to clone with --recurse-submodules so snapd-testing-tools is available for Spread tests. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. | |
| #2183 tests: add spread suite for cmake plugin | snapcraft | merged | Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830. | |
| #5845 test(spread): test building base and snapd snaps | snapcraft | merged | Merged as fb8c81e8f, adding manual Spread coverage that builds current base snaps and the snapd snap against mainline Snapcraft. |