tests: check for submodules before running spread
Metadata
Current evaluation
Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing.
Resolution: closed resolved
Reason: PR #240 was approved and merged, adding a check for the required snapd-testing-tools submodule before spread tests run. The resolution is recorded in commit 3d940f71.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Spread tests require the [snapd-testing-tools](https://github.com/snapcore/snapd-testing-tools) submodule. If the submodule has not been fetched, then a useful error is provided.
Same as https://github.com/canonical/charmcraft/pull/1084
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #240 (commit 3d940f71) added a preflight check in spread.yaml that exits with a "fetch submodules" error when the snapd-testing-tools submodule is empty; ports charmcraft#1084. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #240 (commit 3d940f71) added a pre-spread check that verifies the snapd-testing-tools submodule was fetched and emits a useful error otherwise. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4105 adds a preflight check for the snapd-testing-tools submodule, giving spread tests a clear error when it has not been fetched. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding a pre-check for the snapd-testing-tools submodule before running spread tests. The update ensures a clear error message is displayed if the submodule is missing, preventing cryptic test failures. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1084
(confidence 100%)
Explicitly cited as the equivalent implementation in the PR description.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4105 tests: check for submodules before running spread | snapcraft | merged | Merged PR #4105 in commit 7921b04ed, adding a Spread preflight check that stops with a clear error when the snapd-testing-tools submodule is missing. | |
| #1084 tests: check for submodules before running spread | charmcraft | merged | Merged PR #1084 as commit bc890e84, adding a preflight check that clearly reports when the snapd-testing-tools submodule is missing before Spread tests run. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825. | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #2183 tests: add spread suite for cmake plugin | snapcraft | merged | Merged PR #2183 as commit 51518dbe6, moving CMake plugin and snapd integration tests into a Spread suite and resolving LP #1783830. | |
| #2937 spread tests: do not attempt to remove snapd snap | snapcraft | merged | Merged in commit b9290bb32; spread tests now skip removing the protected snapd snap, fixing LXD test failures. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged PR #2381 as cce7842e8, adding snapd's spread-shellcheck tool, expanding ShellCheck coverage to spread tests, and correcting affected glob patterns. | |
| #2206 tests: add spread suite for catkin plugin | snapcraft | merged | PR #2206 merged as commit 317d4a03a, converting Catkin plugin and snapd integration tests into a Spread suite and resolving LP bug #1783828. |