tests: check for submodules before running spread
Metadata
Current evaluation
Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully.
Suggested action: —
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Spread tests require the [snapd-testing-tools](https://github.com/snapcore/snapd-testing-tools) submodule. If the submodule has not been fetched, then a useful error is provided.
Same as https://github.com/canonical/charmcraft/pull/1084
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds a pre-check for the snapd-testing-tools submodule before running spread tests, providing a clear error if missing. Approved by two reviewers, passed CI, and merged successfully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding a pre-check for the snapd-testing-tools submodule before running spread tests. The update ensures a clear error message is displayed if the submodule is missing, preventing cryptic test failures. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added a pre-run check for the snapd-testing-tools submodule in spread tests, providing a clear error message if missing instead of failing silently. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4105 tests: check for submodules before running spread | snapcraft | merged | Merged. Adds a pre-run check for the snapd-testing-tools submodule in spread tests to provide a clear error if missing. Approved by two reviewers, passed CI, and introduced no coverage changes. | |
| #1084 tests: check for submodules before running spread | charmcraft | merged | Merged changes verifying the snapd-testing-tools submodule before running Spread tests. Adds a clear error if missing. Approved by a reviewer, passed CI, and merged with minimal modifications. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | Merged to master, consolidating Autotools plugin and snapd tests into a single Spread suite to resolve Launchpad bug #1783825. The commit modifies six files, reduces code by 16 lines, passed CI checks, and received reviewer approval prior to integration. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged an improved snap inspector test that emulates system setup by stopping snapd, clearing device files, setting a global proxy, and restarting snapd to uncover network requests. Approved by two reviewers, passed all CI checks, and merged. | |
| #1029 fix(testing): error early if spread.yaml is invalid. | craft-application | merged | Merged after two approvals. Adds early validation to fail tests immediately if spread.yaml is invalid. CI passed except for an unrelated snap-test failure, which was overridden. | |
| #62 spread: add a "big" spread test | rockcraft | merged | Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks. | |
| #5389 test(spread): trace logs in spread tests | snapcraft | merged | Merged after approval. Added trace logging to spread tests. Despite CI failures from extra snapcraft output, the change was approved and merged following a related feature branch integration to prevent conflicts. | |
| #2978 tests: add microk8s spread test | snapcraft | merged | Merged after single reviewer approval and passing CI. Adds a spread test to verify microk8s builds and installs correctly, deferring instrumentation to a future update. Changes affect 2 files (+35/-0 lines). | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%. |