← Back to issue list

style(ci): enable mypy

View original Github issue

Metadata

Project
charmcraft
Number
#1312
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged after two approvals. Enables mypy in CI, modifying 14 files (+70/-33). A related spread test fix was handled in a separate PR.

Suggested action: —

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Enables mypy in CI, modifying 14 files (+70/-33). A related spread test fix was handled in a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable mypy static type checking in CI. A related spread test failure was resolved in PR #1322. The change integrates mypy into the continuous integration workflow to enforce type safety.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable mypy type checking in CI. A related spread test failure was resolved in PR #1322. The change successfully integrates static type analysis into the continuous integration workflow.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#253 style: drop mypy, pyright craft-archives merged Merged after approval and passing CI. Removes mypy and pyright, replacing them with ty; 13 files changed (+16/-506).
76%
#421 style: drop mypy, pyright craft-store merged Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
75%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
75%
#6034 style: fix mypy warnings snapcraft merged Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch.
75%
#856 style: update mypy and fix linting issues craft-application merged Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.
74%
#1706 style: drop mypy, pyright craft-parts merged Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue.
73%
#5313 style: enable pyupgrade rules snapcraft merged Merged. Enables additional pyupgrade rules to modernize Python syntax across 33 files. Approved by two reviewers, passed all CI checks and linting, and integrated into the main branch.
70%