← Back to issue list

style(ci): enable mypy

View original Github issue

Metadata

Project
charmcraft
Number
#1312
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1312 as 28245812, enabling mypy in CI and adding typing fixes across 14 files. Follow-up PR #1322 repaired the strict-dependencies spread test.

Resolution: closed resolved

Reason: PR #1312 merged into main as commit 28245812, adding the lint-mypy target and related typing fixes. The maintainer noted that the remaining spread-test issue was fixed by merged PR #1322 in commit 7c3170d3.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1312 as 28245812, enabling mypy in CI and adding typing fixes across 14 files. Follow-up PR #1322 repaired the strict-dependencies spread test.
stealth/space-bunny-alpha — closed resolved Merged as commit 28245812: enabled mypy type checking in charmcraft CI (lint-mypy target in common.mk) with typing fixes across 14 files. Follow-up #1322 fixed the strict-dependencies spread test.
stealth/space-bunny-alpha — closed resolved Merged in charmcraft#1312, enabling mypy in CI with typing-related changes across 14 files (+70/-33).
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Enables mypy in CI, modifying 14 files (+70/-33). A related spread test fix was handled in a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable mypy static type checking in CI. A related spread test failure was resolved in PR #1322. The change integrates mypy into the continuous integration workflow to enforce type safety.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/charmcraft#1322 (confidence 99%)

    Merged follow-up that fixed the strict-dependencies spread test identified on PR #1312.

Related issues

Issue Project State Summary Similarity
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
73%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
72%
#6034 style: fix mypy warnings snapcraft merged Style-only PR merged as commit 2104678b1 ("style: fix mypy warnings (#6034)"), clearing 2 mypy warnings in one file (+5/-2) with 2 approvals; lint/fast tests passed.
71%