style: fix mypy warnings
Metadata
Current evaluation
Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch.
Suggested action: —
No scores available.
Issue body
Fixes 2 mypy warnings.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer pull request resolving two mypy type-checking warnings. All lint and test checks passed, and the changes were successfully integrated into the repository. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged maintainer mr-cal's changes that resolve two mypy type-checking warnings. The pull request passed linting and testing checks before integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #856 style: update mypy and fix linting issues | craft-application | merged | Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions. | |
| #479 style: drop mypy, pyright | craft-cli | merged | Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files. | |
| #421 style: drop mypy, pyright | craft-store | merged | Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files. | |
| #1706 style: drop mypy, pyright | craft-parts | merged | Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue. | |
| #2807 meta: address errors from mypy uprev | snapcraft | merged | Merged following two reviewer approvals and passing CI. Resolves mypy type-checking errors from a version upgrade. Changes are mostly non-runtime affecting, with minor improvements to edge-case handling across six files. | |
| #215 style: drop mypy, pyright | craft-grammar | merged | Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files. | |
| #56 build(deps): update dependency mypy to ~=1.19.0 (main) | craft-artifacts | merged | Merged dependency update upgrading mypy from 1.18.1 to 1.19.0. Approved by two reviewers, passed CI checks, and modified two files. A single typecheck warning did not block the merge. | |
| #486 docs: fixed broken references | craft-parts | merged | Merged after rebasing on main to resolve a mypy test failure caused by a pydantic 2.0 update. Approved by three reviewers, the change fixes broken documentation references across four files. | |
| #223 style: switch from mypy+pyright to ty | craft-platforms | merged | Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines. | |
| #1312 style(ci): enable mypy | charmcraft | merged | Merged after two approvals. Enables mypy in CI, modifying 14 files (+70/-33). A related spread test fix was handled in a separate PR. |