style: fix mypy warnings
Metadata
Current evaluation
Style-only PR merged as commit 2104678b1 ("style: fix mypy warnings (#6034)"), clearing 2 mypy warnings in one file (+5/-2) with 2 approvals; lint/fast tests passed.
Resolution: closed resolved
Reason: The pull request itself was merged into main as commit 2104678b1, satisfying the PR body checkbox "I've successfully run make lint && make test" with the lint/files and Fast tests checks passing.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes 2 mypy warnings.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Style-only PR merged as commit 2104678b1 ("style: fix mypy warnings (#6034)"), clearing 2 mypy warnings in one file (+5/-2) with 2 approvals; lint/fast tests passed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 2104678b1, fixing two mypy warnings in one file (+5/-2) with two approvals; integration-spread-tests-store was listed as failing. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a maintainer pull request resolving two mypy type-checking warnings. All lint and test checks passed, and the changes were successfully integrated into the repository. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2222 style: fix linting issues | charmcraft | merged | Merged PR #2222 as commit 31c109b4, applying style-only lint fixes across three files (+8/-9) with two approvals. | |
| #20 style: fix linting issues | craft-artifacts | merged | Merged PR #20 via commit 04cbdc0, applying style-only lint fixes across four files (+11/-5); both reviews approved and all CI checks passed. | |
| #1126 style: fix ty errors | craft-application | merged | Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors. | |
| #253 style: drop mypy, pyright | craft-archives | merged | Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed. | |
| #1312 style(ci): enable mypy | charmcraft | merged | Merged PR #1312 as 28245812, enabling mypy in CI and adding typing fixes across 14 files. Follow-up PR #1322 repaired the strict-dependencies spread test. | |
| #479 style: drop mypy, pyright | craft-cli | merged | Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed. | |
| #1204 style: fix linting issues | craft-parts | closed | Lint-only cleanup landed in commit a0622b31, matching PR #1204’s title; all reported CI checks passed. |