← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-archives
Number
#253
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.

Resolution: closed resolved

Reason: Resolved by merged PR #253, recorded as commit 1949f53. The change removed mypy and pyright from the lint tooling and adopted ty; all reported checks passed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Drops mypy and pyright in favor of ty. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-archives/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-archives#253, replacing mypy and pyright with ty across 13 files; two reviewers approved and all reported CI checks passed.
qwen/qwen3.8-27b — — Merged after approval and passing CI. Removes mypy and pyright, replacing them with ty; 13 files changed (+16/-506).
qwen/qwen3.8-27b
Impact: 15
Quick Win: 12
Staleness: 0
Complexity: 20
Confidence: 90
needs review Drops mypy and pyright type checkers in favor of ty, removing ~500 lines of config across 13 files (pyproject, Makefile, CI workflows, uv.lock). Fresh PR, approved by one reviewer, all CI checks passing, ready to land.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 10
Staleness: 5
Complexity: 30
Confidence: 85
needs review Drops mypy and pyright type checkers in favor of ty, touching 13 files (-506/+16). Fresh PR (0 days old) by a maintainer with 0 reviews; CI partially pending, no failures.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
89%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
88%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
88%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
87%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
82%
#421 style: drop mypy, pyright craft-store merged Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
81%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
81%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
80%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
80%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
80%