refactor: merge feature/craft-application
Metadata
Current evaluation
Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI.
Suggested action: —
No scores available.
Issue body
With this pull request we finally finish the work of migrating Rockcraft to craft-application. The number of commits and files is huge because it's a rebase of the `feature/craft-application` branch onto `main`, so all but the very last commit have already been reviewed. The last commit bumps craft-application to 1.0.0 and updates some other minor libs.
I'm going to keep this as a draft until we've agreed on the merge and the communication regarding it (as there are some breaking changes). Many thanks to everyone who worked on this (and reviewed the many PRs) these past few weeks/months.
-------------------------
Fixes #316
Fixes #355
Fixes #358
Fixes #359
Fixes #360
Fixes #370
Fixes #383
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application. The final commit bumps craft-application to 1.0.0, introduces breaking changes, and resolves issues #316, #355, #358, #359, #360, #370, and #383. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged feature/craft-application into main, finalizing Rockcraft's migration to craft-application. Introduces breaking changes, bumps craft-application to 1.0.0, and fixes #316, #355, #358, #359, #360, #370, #383. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #354 refactor: use craft-application for "pack" | rockcraft | merged | Merged a refactor routing rockcraft pack to the new craft-application-based runner, resolving issue #316. The update spans 24 files with 935 additions and 40 deletions, received two approvals, and passed CI checks. | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests. | |
| #715 refactor: use craft-platform for the build plans | rockcraft | merged | Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files. | |
| #4682 refactor(app): use more code from craft-app | snapcraft | merged | Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines. | |
| #1563 fix: breaking changes from craft-application main | charmcraft | merged | Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #527 Merge craft-application update into main | rockcraft | merged | Merged the craft-application branch into main, updating the dependency to version 2.4.0. Approved by two reviewers, rebased onto main, and successfully passed CI checks before being rebase-merged. | |
| #5349 refactor: rebase onto craft-application 5 | snapcraft | merged | Merged after two approvals. Rebases the codebase onto craft-application 5, updating 45 files and potentially resolving issue #5083. Aligns with related upstream craft-application fixes. | |
| #521 refactor: port code to latest craft-app update | rockcraft | merged | Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines). |