refactor: merge feature/craft-application
Metadata
Current evaluation
Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues.
Resolution: closed resolved
Reason: PR #395 was approved by two reviewers and merged after rebasing feature/craft-application onto main. Its final changes bumped craft-application to 1.0.0 and explicitly fixed #316, #355, #358, #359, #360, #370, and #383.
Evaluated by: mr-cal-bot
No scores available.
Issue body
With this pull request we finally finish the work of migrating Rockcraft to craft-application. The number of commits and files is huge because it's a rebase of the `feature/craft-application` branch onto `main`, so all but the very last commit have already been reviewed. The last commit bumps craft-application to 1.0.0 and updates some other minor libs.
I'm going to keep this as a draft until we've agreed on the merge and the communication regarding it (as there are some breaking changes). Many thanks to everyone who worked on this (and reviewed the many PRs) these past few weeks/months.
-------------------------
Fixes #316
Fixes #355
Fixes #358
Fixes #359
Fixes #360
Fixes #370
Fixes #383
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #395 rebased feature/craft-application onto main, completing the migration to craft-application 1.0.0 and fixing #316, #355, #358, #359, #360, #370, and #383. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#395, completing Rockcraft's migration to craft-application 1.0.0. This breaking-change refactor explicitly fixes #316, #355, #358, #359, #360, #370, and #383. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged feature/craft-application into main, completing Rockcraft's migration to craft-application. The final commit bumps craft-application to 1.0.0, introduces breaking changes, and resolves issues #316, #355, #358, #359, #360, #370, and #383. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/rockcraft#316
(confidence 99%)
Migration of rockcraft pack onto craft-application was explicitly fixed by PR #395.
-
Likely Fixed By:
canonical/rockcraft#355
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
-
Likely Fixed By:
canonical/rockcraft#358
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
-
Likely Fixed By:
canonical/rockcraft#359
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
-
Likely Fixed By:
canonical/rockcraft#360
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
-
Likely Fixed By:
canonical/rockcraft#370
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
-
Likely Fixed By:
canonical/rockcraft#383
(confidence 95%)
Explicitly listed as fixed by merged PR #395.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4545 Merge feature/craft-application to main | snapcraft | closed | Merged initial craft-application support into main via PR #4560 at commit 98550856e, completing the requested feature-branch integration. | |
| #4468 feature/craft-application: migrate version command | snapcraft | closed | Version command migration to craft-application landed in merged PR #4614 (commit 885106d06), completing the work drafted in 24d48da8 and closing the tracking issue ahead of the craft-application rebase. | |
| #4830 refactor: migrate commands to craft-application | snapcraft | merged | Merged #4830 as commit 0bee3723c, migrating remaining commands to core24/craft-application; init, list-plugins, and command reference docs now use core24. | |
| #1399 feat: craft-application rebase | charmcraft | merged | Merged PR #1399 (commit 3ba803d1) rebased Charmcraft onto craft-application for CRAFT-2239, a 109-file rewrite of the CLI foundation; cmatsuoka approved merging with remaining issues deferred to follow-up PRs. | |
| #1397 chore: merge main to craft-application feature branch | charmcraft | merged | Merged main into the craft-application feature branch, approved by two reviewers; the merge manually set craft-application to 1.1.0. The feature was completed in #1399. | |
| #4585 chore: merge main into feature/craft-application | snapcraft | merged | Merged main into feature/craft-application via PR #4585 after two approvals; the sync changed 17 files (+345/-93) with no unresolved review comments. | |
| #1356 chore: merge main into craft-application branch | charmcraft | merged | Merged #1356 into the craft-application branch, synchronizing main across 13 files (+82/-74); the broader migration continued in #1399 (3ba803d1). | |
| #856 refactor: use craft-application 5 | rockcraft | merged | Merged as commit 2139bcd2: refactored Rockcraft onto craft-application 5 (49 files, +959/-915) after approval from 3 reviewers; later bumped to craft-application 6.0 via #1027. | |
| #359 Migrate remaining lifecycle commands to craft-application | rockcraft | closed | Resolved by rockcraft PR #395, merged into main; commits e28d53f7 and 0b44fd60 removed legacy lifecycle commands and completed the craft-application migration. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition. |