refactor: remove unused fetch-lib command
Metadata
Current evaluation
PR #1663 (commit b3d35e6d) merged, deleting the unused pre-craft-application fetch-lib implementation; the public fetch-lib command was kept and #1665 added fetch-libs for charmcraft.yaml-declared libraries.
Resolution: closed resolved
Reason: The refactor PR was approved and merged as commit b3d35e6d ("refactor: remove unused fetch-lib command"), removing ~597 lines across 4 files of dead code. Maintainer lengau clarified in the closing comments that only the unused implementation was dropped, not the user-facing fetch-lib command.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1663 (commit b3d35e6d) merged, deleting the unused pre-craft-application fetch-lib implementation; the public fetch-lib command was kept and #1665 added fetch-libs for charmcraft.yaml-declared libraries. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1663 by lengau merged (commit b3d35e6d), deleting the unused pre-craft-application fetch-lib implementation. The public fetch-lib command stays; #1665 added the newer fetch-libs. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1663 (b3d35e6d), removing only the unused pre-craft-application fetch-lib implementation. The public fetch-lib command remains available; #1665 added fetch-libs. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of an unused internal fetch-lib command implementation. The public charmcraft fetch-lib command remains available. Approved by three reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of an unused pre-craft-application fetch-lib implementation. The command itself remains available. Library management will transition to charmcraft.yaml and the fetch-libs command. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#1665
(confidence 90%)
Merged commit 38ea17d6 added the newer fetch-libs command that supersedes the removed pre-craft-application fetch-lib flow
-
Related To:
canonical/charmcraft#1701
(confidence 55%)
Follow-up fix (3af2c248) for fetch-libs naming with underscores
-
Related To:
canonical/charmcraft#1702
(confidence 50%)
Follow-up fix (1da46c8f) allowing fetch-libs to work without logging in
-
Related To:
canonical/charmcraft#2084
(confidence 40%)
Later error-message improvement for the retained fetch-lib command (d0410f22)
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1665 feat: add fetch-libs command | charmcraft | merged | Merged PR #1665 added Charmcraft's fetch-libs command; implementation landed in commit 38ea17d6. | |
| #1788 `fetch-lib` should work from anywhere | charmcraft | open | `fetch-lib` regressed in Charmcraft 3.1.1 by requiring charmcraft.yaml outside projects; a minimal reproducer was provided, and a maintainer explicitly kept the compatibility request open. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #533 Improved the list-lib command's help (CRAFT-508). | charmcraft | merged | Merged PR #533 (commit 706e5c15, CRAFT-508) by facundobatista reworked the list-lib help to show sample output and how to build a fetch-lib command from it, closing #377. Later superseded: fetch-lib removed in #1663. | |
| #806 Add `--force` option to `charmcraft fetch-lib` | charmcraft | closed | --force was not added; merged PR #1665 introduced fetch-libs, which updates declared libraries despite local modifications. | |
| #2503 [WIP] Fix fetch-lib error in charmcraft causing library not found | charmcraft | closed | PR #2503 was closed unmerged as unfinished WIP; tests, review, and security checks were not completed. The fetch-lib “Library None” bug remains, while PR #2505 is still open. | |
| #2504 [WIP] Fix fetch-lib error in charmcraft 3.4.3 | charmcraft | closed | Closed unmerged without tests, review, or CodeQL; the WIP fix was abandoned, while follow-up PR #2505 remains open for issue #2204. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573. |