← Back to issue list

chore: add typing to env.py

View original Github issue

Metadata

Project
charmcraft
Number
#1764
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a chore update adding type annotations to env.py. The change modified two files (+14/-13 lines), received approval from two reviewers, and passed all checks without unresolved comments.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a chore update adding type annotations to env.py. The change modified two files (+14/-13 lines), received approval from two reviewers, and passed all checks without unresolved comments.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer contribution adding static type annotations to env.py. The change enhances static type checking without altering runtime behavior.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer-submitted change adding type hints to env.py. The pull request was accepted without review comments and integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#128 chore: skip typing checkers in "_version.py" starbase merged Merged a chore to skip typing checkers in _version.py. Approved by two reviewers and passed all CI checks. The change adds seven lines with zero coverage impact, serving as an upstream dependency for related repositories.
79%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
78%
#328 chore: change type checking to use `ty` imagecraft merged Switched type checking to ty, resolving issue 263. Merged after two approvals and passing CI checks. Changes span three files with minimal code adjustments.
75%
#621 chore: update fileset and organize docstrings craft-parts merged Merged a chore pull request updating the fileset and organizing docstrings. Changes affected two files (+22/-9 lines). Approved by two reviewers, passed CI checks, and was successfully merged by the maintainer.
75%
#158 chore: update docstrings debcraft merged Merged updates to public function docstrings, adding missing parameters and return values. Approved by two reviewers, passed CI checks, and modified 10 files with 55 additions and 9 deletions.
74%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
73%
#557 chore(deps): update type checkers craft-parts merged Updating type checker dependencies was approved by two reviewers, passed CI checks, and successfully merged into the repository.
73%
#399 chore(lint): set user-provided pyright venv craft-application merged Merged a maintainer's chore to switch pyright from a tox-provided to a user-provided virtual environment. Approved by two reviewers, passed CI, and removed two lines from one file.
72%
#2028 chore: two small non-code changes charmcraft merged Merged following approval from two reviewers. The pull request implements two minor non-code changes across two files, yielding a five-line addition and two-line deletion diff. No code modifications were included.
72%
#764 chore: fixes to things linking to the gnu website craft-parts merged Merged a chore update fixing links to the GNU website. Approved by two reviewers, passed CI, and modified two files with five additions and three deletions.
72%