← Back to issue list

chore: skip typing checkers in "_version.py"

View original Github issue

Metadata

Project
starbase
Number
#128
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #128 as commit edf7d5a, excluding setuptools_scm-generated _version.py from mypy and Pyright checks.

Resolution: closed resolved

Reason: PR #128 was approved and merged into main as commit edf7d5a, adding exclusions so generated version files are skipped by typing checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- upstream of https://github.com/canonical/craft-providers/pull/404 and https://github.com/canonical/craft-application/pull/82

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #128 as commit edf7d5a, excluding setuptools_scm-generated _version.py from mypy and Pyright checks.
stealth/space-bunny-alpha — closed resolved Merged PR #128 (commit edf7d5a) added typing-checker skips in _version.py; approved by two reviewers and identified as upstream for craft-providers#404 and craft-application#82.
qwen/qwen3.6-35b-a3b — — Merged a chore to skip typing checkers in _version.py. Approved by two reviewers and passed all CI checks. The change adds seven lines with zero coverage impact, serving as an upstream dependency for related repositories.
qwen3.6-35b-a3b-mtp-q6 — — Merged a chore to skip typing checkers in _version.py. Serves as the upstream fix for related canonical repositories, with no impact on code coverage.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#82 chore: skip typing checkers in "_version.py" craft-application merged Merged PR #82 as commit 1ec888d8, excluding setuptools_scm-generated _version.py from mypy and pyright to avoid false-positive typing errors.
95%
#404 chore: skip typing checkers in "_version.py" craft-providers merged Merged PR #404 via commit 371d77c excludes _version.py from typing checks and explicitly excludes hidden and cache paths once exclusion is configured.
82%
#158 chore: fix pyright error craft-archives merged Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
74%
#158 chore: use new mypy config `extra_checks` starbase merged Merged PR #158 as commit 86b7568, replacing mypy's deprecated strict_concatenate option with extra_checks.
73%
#4406 chore: ignore types snapcraft merged Merged PR #4406 as feb701d30, suppressing pkg_resources type errors from pyright 1.1.332 and unblocking PEP 518 support in #4087.
72%
#457 chore: remove unused mypy and pyright configuration imagecraft merged Merged PR #457 (maintainer lengau) deleted unused [tool.mypy]/[[tool.mypy.overrides]] and [tool.pyright] config plus the mypy[reports] dep and uv.lock entries (-229 lines), cleaning up leftovers after the ty migration.
72%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
72%
#122 chore: eliminate pydantic warnings craft-archives merged Merged PR #122 eliminated Pydantic warnings, landing as commit 00b9b3b after approval by two reviewers.
71%
#784 chore(deps): update bugfixes craft-parts merged Merged PR #784 in commit 764786e7, updating pyright 1.1.358→1.1.372 and tox-gh 1.3→1.3.2.
70%
#439 chore(linter): misc fix rockcraft merged Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main.
70%