← Back to issue list

chore(lint): set user-provided pyright venv

View original Github issue

Metadata

Project
craft-application
Number
#399
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a maintainer's chore to switch pyright from a tox-provided to a user-provided virtual environment. Approved by two reviewers, passed CI, and removed two lines from one file.

Suggested action:

No scores available.

Issue body

This removes using the tox-provided pyright venv - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a maintainer's chore to switch pyright from a tox-provided to a user-provided virtual environment. Approved by two reviewers, passed CI, and removed two lines from one file.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer's pull request replacing the tox-provided pyright virtual environment with a user-provided one. The change updates linting configuration to support custom pyright installations without requiring additional review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 chore: fix pyright error craft-archives merged Merged a maintainer's pull request that resolved a pyright error by removing a single line. Approved by three reviewers and passed CI checks before integration.
84%
#117 chore: fix pyright config craft-store merged Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.
79%
#439 chore(linter): misc fix rockcraft merged Merged linter chore PR fixing miscellaneous issues and an unexpected pyright error from a rebase onto main. Approved by two reviewers, changes span 16 files with 86 additions and 76 deletions.
78%
#784 chore(deps): update bugfixes craft-parts merged Merged automated dependency updates for pyright to 1.1.372 and tox-gh to 1.3.2. Approved by two reviewers, passed CI checks, and auto-merged via Renovate configuration.
77%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
74%
#621 chore: update fileset and organize docstrings craft-parts merged Merged a chore pull request updating the fileset and organizing docstrings. Changes affected two files (+22/-9 lines). Approved by two reviewers, passed CI checks, and was successfully merged by the maintainer.
73%
#234 chore(deps): update dependency pyright to v1.1.375 starbase merged Merged an automated dependency update for pyright from v1.1.372 to v1.1.375. Approved by a reviewer, passed CI checks, and automatically merged via Renovate bot.
73%
#70 chore(deps): update pyright to v1.1.309 starbase merged Merged automated dependency update for pyright and types/pyright from v1.1.308 to v1.1.309. Approved by one reviewer, passed CI checks, and merged automatically via Renovate bot configuration.
72%
#1764 chore: add typing to env.py charmcraft merged Merged a chore update adding type annotations to env.py. The change modified two files (+14/-13 lines), received approval from two reviewers, and passed all checks without unresolved comments.
72%
#4550 chore(deps): update black and pyright snapcraft merged Merged to fix CI failures triggered by a Black and pyright dependency update. Approved by two reviewers and merged despite unrelated failing CI checks for devel images.
72%