← Back to issue list

chore: clean up unused/unnecessary files

View original Github issue

Metadata

Project
charmcraft
Number
#2444
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged maintenance PR #2444 (commit 6b94f660) removing 286 lines across 10 unused/unnecessary files after two approvals; macOS smoke-test jobs failed but did not block the merge.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 6b94f660 ('chore: clean up unused/unnecessary files (#2444)'), approved by two reviewers, with +3/-286 lines across 10 files. Only the macos-smoke-test jobs failed and the change was merged regardless.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged maintenance PR #2444 (commit 6b94f660) removing 286 lines across 10 unused/unnecessary files after two approvals; macOS smoke-test jobs failed but did not block the merge.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2444 as 6b94f660, deleting 286 lines across 10 unused or unnecessary files after two approvals.
qwen/qwen3.6-35b-a3b — — Merged a chore change removing 286 lines across 10 unused files. Approved by two reviewers and integrated despite non-blocking macOS test failures and type checker warnings.
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup of unused and unnecessary files. Automated type-checking warnings were informational only and did not block integration. Changes were successfully merged into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#1907 (confidence 55%)

    Earlier 'chore(cleanup): remove unused code' cleanup (commit d590c429), part of the same dead-code removal effort.

  • Related To: canonical/charmcraft#1776 (confidence 50%)

    Similar 'chore: remove unused code' cleanup PR (commit 027696be) removing ~17.5k lines across 36 files.

  • Related To: canonical/charmcraft#490 (confidence 30%)

    Later chore removing unused docs dependencies, same unused-dependency cleanup theme.

Related issues

Issue Project State Summary Similarity
#1776 chore: remove unused code charmcraft merged Merged PR #1776 as commit 027696be, deleting 17,571 lines of unused code across 36 files after maintainer review and approval.
82%
#117 chore: clean up cruft craft-actions closed Merged PR #117 as commit 37d00fc, removing 117 lines from nine files to clean repository cruft ahead of v1.
76%
#6079 chore: delete unused file snapcraft merged Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup.
76%
#1357 chore: remove unused docs requirements file craft-parts merged Merged #1357 as commit b472871d, deleting the unused 349-line docs/requirements.txt to stop needless Renovate PR noise; all CI checks passed.
74%
#1099 chore: fix linting craft-application merged Merged as 4c674c21, updating two files to clear Ty unused-directive lint errors; lint/files passed and review was approved.
73%
#6421 chore(merge): 9.1.1 into main snapcraft merged Merged the 9.1.1 hotfix branch into main via PR #6421 (+378/-23, 12 files) after two approvals; author mr-cal noted the single lint failure was an unrelated link-checker problem.
72%
#2682 chore: delete some dead code charmcraft merged Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.
72%
#1547 chore: merge main into feature/12f charmcraft merged Merged main into feature/12f as a single merge commit (+9828/-2082) to refresh the branch and keep the snapstore channel open; approved by 2 reviewers. macOS extension test timeouts were flagged but deemed non-blocking.
71%
#513 chore: merge 4.2.6 to main craft-application merged Merged release 4.2.6 into main via approved PR #513 at commit 67bd5dd9, updating four files (+62/-4).
71%
#1040 chore(merge): 2.4.3 into main craft-parts merged Merged version 2.4.3 into main via PR #1040, landing as commit fab7fa92 after two reviewer approvals.
71%