style(type): add ty ignores
Metadata
Current evaluation
Closed without merging. The PR adding ty type ignores remained unreviewed with unresolved comments and multiple failing CI checks. The change was abandoned.
Suggested action: —
No scores available.
Issue body
This is just the output of `ty check --add-ignore`
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The PR adding ty type ignores remained unreviewed with unresolved comments and multiple failing CI checks. The change was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The PR added ty type ignore comments but triggered failing CI checks for snap-tests and docs-tests. The bot flagged unused type ignore directives in test files. No reviewers engaged, leading to abandonment. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Failing CI tests and bot warnings about unused type ignore directives blocked approval. The automated ty suppressions were abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments, failing CI documentation tests, and unused type ignore warnings. The PR introduced automatic ty suppressions but stalled without maintainer review. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to failing CI tests and lack of reviewer approval. Changes adding ty type-checking ignores were abandoned after tests failed and no updates were made for over a month. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed after passing ty type checks, though unused ignore directives were flagged in test files. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
30
Complexity:
10
Confidence:
85
|
needs review | Adds ty type-checking ignore directives generated by ty check --add-ignore. Type checking passes but the bot flags unused ignore comments in test files. Awaiting review or cleanup to remove unnecessary suppressions. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #977 style(lint): go all-in on ty | craft-providers | closed | Closed without merge. The PR introduced minor lint changes but remained unreviewed with two unresolved comments and failing CI checks, indicating it was abandoned. | |
| #1908 style(type): stricter type checking | charmcraft | closed | Closed without merge. The stricter type checking changes across 19 files received no reviews or CI checks and were abandoned due to inactivity. | |
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. | |
| #60 ci: get ty from beta | craft-artifacts | closed | Closed without merging after the typecheck-with-ty CI check failed. Although approved by a reviewer, the change to fetch ty from beta was abandoned. | |
| #27 ci: type check with ty | craft-artifacts | merged | Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes. | |
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #6045 fix(type): update ty config for unused-ignore-comment | snapcraft | merged | Merged a configuration update renaming unused-ignore-comment to unused-type-ignore-comment, ensuring compatibility with ty linter version 0.0.15 and higher. Approved by reviewers and passed all CI checks. | |
| #5993 style: configure ty | snapcraft | merged | Merged PR configuring the ty type checker with directory exclusions and suppressing unused-ignore-comment warnings in pyproject.toml. Follow-up PRs will address remaining warnings. |