style(type): add ty ignores
Metadata
Current evaluation
Closed unmerged; its generated ty ignores were superseded by merged PR #2726 (f2e05e81), which switched Charmcraft to ty with targeted suppressions.
Resolution: closed superseded
Reason: PR #2692 closed without being merged or receiving a resolving commit. Merged PR #2726 introduced ty type checking and its own targeted suppressions, replacing this generated ignore proposal.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is just the output of `ty check --add-ignore`
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; its generated ty ignores were superseded by merged PR #2726 (f2e05e81), which switched Charmcraft to ty with targeted suppressions. | |
| stealth/space-bunny-alpha | — | closed stale | PR #2692 added ty type-ignore comments but was closed unmerged after remaining unreviewed with unresolved feedback and failing CI checks. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The PR adding ty type ignores remained unreviewed with unresolved comments and multiple failing CI checks. The change was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The PR added ty type ignore comments but triggered failing CI checks for snap-tests and docs-tests. The bot flagged unused type ignore directives in test files. No reviewers engaged, leading to abandonment. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. Failing CI tests and bot warnings about unused type ignore directives blocked approval. The automated ty suppressions were abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments, failing CI documentation tests, and unused type ignore warnings. The PR introduced automatic ty suppressions but stalled without maintainer review. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to failing CI tests and lack of reviewer approval. Changes adding ty type-checking ignores were abandoned after tests failed and no updates were made for over a month. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed after passing ty type checks, though unused ignore directives were flagged in test files. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#2726
(confidence 98%)
Commit f2e05e81 switched type checking to ty; the current tree contains targeted ty:ignore comments.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #938 style: ty | craft-providers | merged | Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version. | |
| #6045 fix(type): update ty config for unused-ignore-comment | snapcraft | merged | Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer. | |
| #902 style: add type ignores | craft-providers | merged | Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI. | |
| #1361 style: suppress ty warning | rockcraft | merged | One-line style PR adding a ty type-ignore to silence ty 0.0.79's false-positive warning that user_files["shadow"] is always "". Approved by one reviewer and merged (+1/-1, 1 file); source-spread-tests was the only red check. |