style: add type ignores
Metadata
Current evaluation
Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI.
Resolution: closed resolved
Reason: PR #902 was approved and merged. Its changes suppress known ty diagnostics with file-specific ignores rather than changing runtime behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Adds type ignores for ty to unblock CI.
Creates https://github.com/canonical/craft-providers/issues/901
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #902 added targeted ty ignore annotations across three files (+11/-6) to unblock CI, and opened follow-up issue #901 for type-checker cleanup. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR adding type ignores for ty to unblock CI. Resolves the CI blocking issue referenced in craft-providers#901. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
canonical/craft-providers#901
(confidence 98%)
The PR was created to unblock CI for the ty migration tracked in #901; it did not complete that broader migration.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1698 style: ty | craft-parts | merged | Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files. | |
| #27 ci: type check with ty | craft-artifacts | merged | Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20. | |
| #335 fix(lint): suppress ty | imagecraft | merged | Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed. | |
| #885 style: enable type checking with ty | craft-providers | merged | Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed. | |
| #2692 style(type): add ty ignores | charmcraft | closed | Closed unmerged; its generated ty ignores were superseded by merged PR #2726 (f2e05e81), which switched Charmcraft to ty with targeted suppressions. | |
| #910 style: fix ty error | craft-providers | merged | Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed. | |
| #139 style(type): fix typing issues found by ty | craft-platforms | merged | Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553. | |
| #938 style: ty | craft-providers | merged | Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version. | |
| #6045 fix(type): update ty config for unused-ignore-comment | snapcraft | merged | Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer. |