← Back to issue list

fix(type): update ty config for unused-ignore-comment

View original Github issue

Metadata

Project
snapcraft
Number
#6045
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
Created
Updated
Closed

Current evaluation

Merged a configuration update renaming unused-ignore-comment to unused-type-ignore-comment, ensuring compatibility with ty linter version 0.0.15 and higher. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

Update `unused-ignore-comment` to `unused-type-ignore-comment` to match the configuration expected by ty ≥ 0.0.15. Related to #5970. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a configuration update renaming unused-ignore-comment to unused-type-ignore-comment, ensuring compatibility with ty linter version 0.0.15 and higher. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged an update to the ty linter configuration, changing unused-ignore-comment to unused-type-ignore-comment for compatibility with ty 0.0.15+. Resolves related issue #5970.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution updating the ty configuration key from unused-ignore-comment to unused-type-ignore-comment for compatibility with ty ≥ 0.0.15. Addresses related issue #5970.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5993 style: configure ty snapcraft merged Merged PR configuring the ty type checker with directory exclusions and suppressing unused-ignore-comment warnings in pyproject.toml. Follow-up PRs will address remaining warnings.
77%
#407 style(types): enable type checking with ty craft-cli merged Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
73%
#27 ci: type check with ty craft-artifacts merged Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes.
73%
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
72%
#446 style(lint): fix typing for ty update craft-cli merged Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.
72%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
72%
#472 style: enable ty by default starbase merged Merged to enable the ty type checker by default. Approved by two reviewers with all CI checks passing. The minimal configuration change lays groundwork for eventually replacing mypy and pyright once ty reaches stable release.
72%
#2692 style(type): add ty ignores charmcraft closed Closed without merging. The PR adding ty type ignores remained unreviewed with unresolved comments and multiple failing CI checks. The change was abandoned.
71%