← Back to issue list

fix(type): update ty config for unused-ignore-comment

View original Github issue

Metadata

Project
snapcraft
Number
#6045
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer.

Resolution: closed resolved

Reason: PR #6045 was approved with all checks passing and merged as commit 23e78c21e, updating the obsolete ty configuration name.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update `unused-ignore-comment` to `unused-type-ignore-comment` to match the configuration expected by ty ≥ 0.0.15. Related to #5970. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer.
stealth/space-bunny-alpha — closed resolved Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer.
qwen/qwen3.6-35b-a3b — — Merged a configuration update renaming unused-ignore-comment to unused-type-ignore-comment, ensuring compatibility with ty linter version 0.0.15 and higher. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged an update to the ty linter configuration, changing unused-ignore-comment to unused-type-ignore-comment for compatibility with ty 0.0.15+. Resolves related issue #5970.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5970 (confidence 100%)

    PR #6045 explicitly identifies the broader ty warnings issue as related.

Related issues

Issue Project State Summary Similarity
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
73%
#2692 style(type): add ty ignores charmcraft closed Closed unmerged; its generated ty ignores were superseded by merged PR #2726 (f2e05e81), which switched Charmcraft to ty with targeted suppressions.
73%
#902 style: add type ignores craft-providers merged Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI.
72%
#5993 style: configure ty snapcraft merged Merged in canonical/snapcraft#5993 (commit c220b3f74), configuring ty exclusions and suppressing unused-ignore warnings without behavioral changes.
71%
#1361 style: suppress ty warning rockcraft merged One-line style PR adding a ty type-ignore to silence ty 0.0.79's false-positive warning that user_files["shadow"] is always "". Approved by one reviewer and merged (+1/-1, 1 file); source-spread-tests was the only red check.
70%