← Back to issue list

ci: filter in qa workflow

View original Github issue

Metadata

Project
charmcraft
Number
#2701
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161.

Resolution: closed resolved

Reason: PR #2701 was merged, implementing the requested QA filtering and passing filters into the lint workflow. It depended on Starflow PRs canonical/starflow#141 and #143.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the filter to the workflow directly, and pass it on to the called lint workflow. Depends on https://github.com/canonical/starflow/pull/141 and https://github.com/canonical/starflow/pull/143. For CRAFT-5161. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#2701, adding QA path filters and passing them to the lint workflow, dependent on Starflow#141 and #143.
qwen/qwen3.6-35b-a3b — — Merged. Adds a filter to the QA workflow and passes it to the lint workflow. Approved by two reviewers. Tests are intentionally skipped to be verified before merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged to address CRAFT-5161. Adds a filter to the QA workflow and passes it to the lint workflow. Reviewer noted this disables test enforcement but accepts it for pre-merge validation.

Update history

No update history recorded yet.

Related work

  • Blocked By: canonical/starflow#141 (confidence 100%)

    Explicitly listed as a prerequisite for the filter workflow changes.

  • Blocked By: canonical/starflow#143 (confidence 100%)

    Explicitly listed as a prerequisite for passing filters to the called lint workflow.

Related issues

Issue Project State Summary Similarity
#1212 ci: add path filter to qa workflow, make jobs conditional rockcraft merged PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes.
83%
#160 ci: add path filter to qa workflow, make jobs conditional debcraft merged Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161).
83%
#6256 ci: add path filter to qa workflow, make jobs conditional snapcraft merged PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows.
82%
#546 docs: add filter to qa workflow starbase merged Merged PR (commit ccb17d2): adds a dorny/paths-filter "filter" job to .github/workflows/qa.yaml so lint/test reusable workflows only run for source files, skipping docs-only PRs.
74%
#1218 ci: add checkout step to qa workflow filter rockcraft merged Merged PR #1218 by medubelko (+4 lines) added an actions/checkout step before dorny/paths-filter in the QA workflow, fixing filter failures on push events; approved with 1 reviewer.
72%
#2710 ci: fix qa workflow conditional charmcraft merged Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running.
71%